59 bytes, text/x-review-board-request
I think that this is a regression of bug 1337078. I tests on Android emulator and Android 8 with Nexus 5X.
status-firefox58: --- → affected
tracking-firefox58: --- → ?
tracking-firefox59: --- → ?
status-firefox57: --- → unaffected
status-firefox-esr52: --- → unaffected
tracking-firefox58: ? → +
tracking-firefox59: ? → +
Comment on attachment 8932002 [details] Bug 1420332 - Use system locale when system default is selected for browser locale. https://reviewboard.mozilla.org/r/203048/#review208950
Attachment #8932002 - Flags: review?(snorp) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5840e049e5aa Use system locale when system default is selected for browser locale. r=snorp
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8932002 [details] Bug 1420332 - Use system locale when system default is selected for browser locale. Approval Request Comment [Feature/Bug causing the regression]: bug 1337078 [User impact if declined]: When user selects system default for browser language, about:addon etc is always en page even if user uses other locale for system. Also, system default is default option, so this issue occurs on most users. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Yes 1. Set system locale is non-US language such as Spanish. 2. Launch Firefox and set system default for browser locale from settings 3. Select [addon] menu - Expected result addon page is 1's locale. [List of other uplifts needed for the feature/fix]: No [Is the change risky?]: Low. [Why is the change risky/not risky?]: When using system locale, we set empty string by bug 1337078. So we return current locale instead of it. [String changes made/needed]: No
Attachment #8932002 - Flags: approval-mozilla-beta?
Comment on attachment 8932002 [details] Bug 1420332 - Use system locale when system default is selected for browser locale. Fix a regression issue that about:support's System Locales is always 'en-US'. Beta58+.
Attachment #8932002 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox58: affected → fixed
You need to log in before you can comment on or make changes to this bug.