about:support's System Locales is always 'en-US' even if Android system is ja-JP.

RESOLVED FIXED in Firefox 58

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

({regression})

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58+ fixed, firefox59+ fixed)

Details

Attachments

(1 attachment)

I think that this is a regression of bug 1337078.  I tests on Android emulator and Android 8 with Nexus 5X.
Priority: -- → P1
Assignee: nobody → m_kato
I verified that this patch fixes bug 1418417 and bug 1419822.
Comment on attachment 8932002 [details]
Bug 1420332 - Use system locale when system default is selected for browser locale.

https://reviewboard.mozilla.org/r/203048/#review208950
Attachment #8932002 - Flags: review?(snorp) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/5840e049e5aa
Use system locale when system default is selected for browser locale. r=snorp
https://hg.mozilla.org/mozilla-central/rev/5840e049e5aa
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8932002 [details]
Bug 1420332 - Use system locale when system default is selected for browser locale.

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1337078

[User impact if declined]:
When user selects system default for browser language, about:addon etc is always  en page even if user uses other locale for system.

Also, system default is default option, so this issue occurs on most users.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes

1. Set system locale is non-US language such as Spanish.
2. Launch Firefox and set system default for browser locale from settings
3. Select [addon] menu

- Expected result
addon page is 1's locale.

[List of other uplifts needed for the feature/fix]:
No

[Is the change risky?]:
Low.

[Why is the change risky/not risky?]:
When using system locale, we set empty string by bug 1337078.  So we return current locale instead of it.

[String changes made/needed]:
No
Attachment #8932002 - Flags: approval-mozilla-beta?
Comment on attachment 8932002 [details]
Bug 1420332 - Use system locale when system default is selected for browser locale.

Fix a regression issue that about:support's System Locales is always 'en-US'. Beta58+.
Attachment #8932002 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.