1420332 - about:support's System Locales is always 'en-US' even if Android system is ja-JP.

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P1)

Description

[Makoto Kato [:m_kato]]

I think that this is a regression of bug 1337078.  I tests on Android emulator and Android 8 with Nexus 5X.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5569c70a4a454fbf26c2c25a3513cd07022a7672

Comment 2

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f156b7c5d8ee817ab0d8edc17e73ea26fb357f18

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1420332 - Use system locale when system default is selected for browser locale.

This is a regression by bug 1337078.  When user selects system default for
Browser language, "locale" pref is empty.  So BrowserLocaleManager.getLocale
always returns null.  So, current locale is always en-US in Gecko code.

So we should return system locale when "locale" pref is empty.

Also, ReadSystemLocales expects language tag string for locale.  Since
Locale.toString doesn't return language tag, so we should convert to it.

Review commit: https://reviewboard.mozilla.org/r/203048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203048/

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

I verified that this patch fixes bug 1418417 and bug 1419822.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8932002 [details]
Bug 1420332 - Use system locale when system default is selected for browser locale.

https://reviewboard.mozilla.org/r/203048/#review208950

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5840e049e5aa
Use system locale when system default is selected for browser locale. r=snorp

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5840e049e5aa

Comment 8

[Makoto Kato [:m_kato]]

Comment on attachment 8932002 [details]
Bug 1420332 - Use system locale when system default is selected for browser locale.

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1337078

[User impact if declined]:
When user selects system default for browser language, about:addon etc is always  en page even if user uses other locale for system.

Also, system default is default option, so this issue occurs on most users.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes

1. Set system locale is non-US language such as Spanish.
2. Launch Firefox and set system default for browser locale from settings
3. Select [addon] menu

- Expected result
addon page is 1's locale.

[List of other uplifts needed for the feature/fix]:
No

[Is the change risky?]:
Low.

[Why is the change risky/not risky?]:
When using system locale, we set empty string by bug 1337078.  So we return current locale instead of it.

[String changes made/needed]:
No

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8932002 [details]
Bug 1420332 - Use system locale when system default is selected for browser locale.

Fix a regression issue that about:support's System Locales is always 'en-US'. Beta58+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9ebc50b8692d