Closed
Bug 1420332
Opened 6 years ago
Closed 6 years ago
about:support's System Locales is always 'en-US' even if Android system is ja-JP.
Categories
(Core :: Internationalization, defect, P1)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | + | fixed |
firefox59 | + | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
snorp
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
I think that this is a regression of bug 1337078. I tests on Android emulator and Android 8 with Nexus 5X.
Assignee | ||
Updated•6 years ago
|
status-firefox58:
--- → affected
tracking-firefox58:
--- → ?
tracking-firefox59:
--- → ?
Keywords: regression
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5569c70a4a454fbf26c2c25a3513cd07022a7672
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → m_kato
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f156b7c5d8ee817ab0d8edc17e73ea26fb357f18
Updated•6 years ago
|
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
I verified that this patch fixes bug 1418417 and bug 1419822.
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8932002 [details] Bug 1420332 - Use system locale when system default is selected for browser locale. https://reviewboard.mozilla.org/r/203048/#review208950
Attachment #8932002 -
Flags: review?(snorp) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/5840e049e5aa Use system locale when system default is selected for browser locale. r=snorp
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5840e049e5aa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee | ||
Comment 8•6 years ago
|
||
Comment on attachment 8932002 [details] Bug 1420332 - Use system locale when system default is selected for browser locale. Approval Request Comment [Feature/Bug causing the regression]: bug 1337078 [User impact if declined]: When user selects system default for browser language, about:addon etc is always en page even if user uses other locale for system. Also, system default is default option, so this issue occurs on most users. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Yes 1. Set system locale is non-US language such as Spanish. 2. Launch Firefox and set system default for browser locale from settings 3. Select [addon] menu - Expected result addon page is 1's locale. [List of other uplifts needed for the feature/fix]: No [Is the change risky?]: Low. [Why is the change risky/not risky?]: When using system locale, we set empty string by bug 1337078. So we return current locale instead of it. [String changes made/needed]: No
Attachment #8932002 -
Flags: approval-mozilla-beta?
Comment 9•6 years ago
|
||
Comment on attachment 8932002 [details] Bug 1420332 - Use system locale when system default is selected for browser locale. Fix a regression issue that about:support's System Locales is always 'en-US'. Beta58+.
Attachment #8932002 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/9ebc50b8692d
Updated•6 years ago
|
Flags: qe-verify+
Updated•6 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•