1420335 - OSPreferenes::ReadDateTimePattern should detect 12h/24h on Android

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P3)

Description

[Makoto Kato [:m_kato]]

Android has API for this.  https://developer.android.com/reference/android/text/format/DateFormat.html#is24HourFormat(android.content.Context)

Comment 1

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/jobs?repo=try&revision=947cabc4d8ae4189de6852ad5567525518e5c987

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1420335 - Make OSPreferences::ReadDateTimePattern check 12h/24h on Android; r=zbraniecki!

As is the case with GTK, Android provides an OS override to display times in
AM/PM or 24 hour format. This moves the code for rewriting skeletons from the
GTK specific code to OSPreferences, and calls it from the Android OSPreferences
implementation.

This was tested manually by visiting the file:/// uri. I don't believe this is
feasible to test from automation, as it would require changing Android OS settings
from within our test code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc9229077eaa
Make OSPreferences::ReadDateTimePattern check 12h/24h on Android; r=zbraniecki

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset dc9229077eaa (bug 1420335) for security/manager* and toolkit/mozapps/* xpc failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=89021962e6156f765d33e0daadbd7c0eff6cb5fb&searchStr=android%2Cxpcshell%2C&tochange=e47ba8d8ca308e23a3208125ef38a09e4e26708f&selectedTaskRun=DcFLld6CTCioTIvVhJou1w.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/e47ba8d8ca308e23a3208125ef38a09e4e26708f

Failures log: https://treeherder.mozilla.org/logviewer?job_id=326701629&repo=autoland&lineNumber=1900

Please see the log, since there are too many failures to fit in a snippet.

Comment 5

[Dan Minor [:dminor]]

Sorry, I'm finding it difficult to figure out which tests to run when I make changes to intl. Unfortunately mach try auto has not been very helpful for this. In this case, it looks like we can't get an android context when running xpcshell tests, so this probably just needs a nullcheck.

Comment 6

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/jobs?repo=try&revision=6759ed9a3339e1b702e5aa706a1f802d18f54863

It is necessary to check mozilla::jni::IsAvailable() before trying to call anything jni related.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc4560067c86
Make OSPreferences::ReadDateTimePattern check 12h/24h on Android; r=zbraniecki

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bc4560067c86