1420349 - this.scheduler is undefined forcing sync very early after startup

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

Immediately after starting up I hit "sync now" and saw in the log:

> 1511503477891	Sync.Service	DEBUG	Exception calling anonymous function: TypeError: this.scheduler is undefined (resource://services-sync/service.js:1047:12) JS Stack trace: [e-mail]:1047:12 < sync/<@service.js:1091:11 < async*[e-mail]:99:22 < async*[e-mail]:1089:12 < async*syncAndReportErrors/<@policies.js:821:7

this.scheduler is setup in onStartup, which is async. I suspect something that should be awaiting that isn't. I'm out of time to dig further but thought I'd get this on file anyway...

Comment 1

[Mark Hammond [:markh] [:mhammond]]

oops - and I meant to add - the next sync worked fine.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

Taking since this is the cause of bug 1421044, I have a patch for it, and eoger said he hasn't started on it yet.

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1420349 - Instantiate the sync scheduler in the service's constructor, instead of in onStartup.

Review commit: https://reviewboard.mozilla.org/r/203588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203588/

Comment 5

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8932539 [details]
Bug 1420349 - Instantiate the sync scheduler in the service's constructor, instead of in onStartup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203588/diff/1-2/

Comment 6

[Edouard Oger [:eoger]]

Comment on attachment 8932539 [details]
Bug 1420349 - Instantiate the sync scheduler in the service's constructor, instead of in onStartup.

https://reviewboard.mozilla.org/r/203588/#review209094

Thank you!
As I discussed with Thom on IRC, the big underlying issue is that we are not awaiting on Weave.Service.promiseInitialized in a bunch of places.
This patch will fix the this.scheduler issue, but we might/will have more issues.
We should fix this once and for all in a follow-up by removing the Service getter from Weave. (or make it throw), and surface an async getService method that does the initializing for us.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a96b2b10be3
Instantiate the sync scheduler in the service's constructor, instead of in onStartup. r=eoger

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7a96b2b10be3