Closed Bug 1420366 Opened 2 years ago Closed 2 years ago

Update the list of checkers in .clang-tidy file in order to remove 'modernize-use-override'

Categories

(Firefox Build System :: Source Code Analysis, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This checker is prone to throw many warnings due to the way how we implement NS_IMETHOD. Since it's very widespread across our code base we cannot change it, since in many cases it's also used in order to create vtables for the corresponding classes. 
I propose to eliminate since besides the semantical benefit it doesn't add nothing valuable.
Comment on attachment 8931617 [details]
Bug 1420366 - remove modernize-use-override from clang-bot config.

https://reviewboard.mozilla.org/r/202774/#review208088

::: .clang-tidy:1
(Diff revision 1)
>  # Checks run by clang-tidy over Mozilla code.

I think we are using tools/clang-tidy/config.yaml
This file is probably useless now, no?
Attachment #8931617 - Flags: review?(sledru)
Yes that one is used for the bot, but if you run by hand clang-tidy this file will be used. OK I will drop this change and remove it from the bot config.
Comment on attachment 8931617 [details]
Bug 1420366 - remove modernize-use-override from clang-bot config.

https://reviewboard.mozilla.org/r/202774/#review208094
Attachment #8931617 - Flags: review?(sledru) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e805540bfd7a
remove modernize-use-override from clang-bot config. r=sylvestre
https://hg.mozilla.org/mozilla-central/rev/e805540bfd7a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.