1420377 - Avoid atomize 'is' value twice when the custom element is created from parser

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Edgar Chen [:edgar]]

The duplicated atomizing is in
* https://searchfox.org/mozilla-central/rev/a5d613086ab4d0578510aabe8653e58dc8d7e3e2/parser/html/nsHtml5TreeOperation.cpp#412
* https://searchfox.org/mozilla-central/rev/a5d613086ab4d0578510aabe8653e58dc8d7e3e2/dom/html/nsHTMLContentSink.cpp#263

Comment 1

[Edgar Chen [:edgar]]

Attachment: Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser;

Review commit: https://reviewboard.mozilla.org/r/202804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202804/

Comment 2

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6acc85307f55d88d1a41878f94e2a2599302850e&filter-tier=1&group_state=expanded

Comment 3

[Edgar Chen [:edgar]]

Comment on attachment 8931632 [details]
Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202804/diff/1-2/

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a089e759f2ab92795d69bd84fd96383aefea251&filter-tier=1&group_state=expanded

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8931632 [details]
Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202804/diff/2-3/

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8931632 [details]
Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202804/diff/3-4/

Comment 7

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c40fe67582418c897caed4e0c875b140f0445f6b&filter-tier=1&group_state=expanded

Comment 8

[Olli Pettay [:smaug]]

Comment on attachment 8931632 [details]
Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser;

https://reviewboard.mozilla.org/r/202804/#review218806

Btw, if there are some very hot code paths in main thread needing atomize, NS_AtomizeMainThread can be a bit faster, at least if it gets called often with same values.
But I don't think any case here is such.

Comment 9

[Edgar Chen [:edgar]]

(In reply to Olli Pettay [:smaug] (please try to find other reviewers for non-web components patches) from comment #8)
> Btw, if there are some very hot code paths in main thread needing atomize,
> NS_AtomizeMainThread can be a bit faster, at least if it gets called often
> with same values.

Nice to learn this. Thank you. :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efc5e53b695b
Avoid atomizing 'is' value twice when the custom element is created from parser; r=smaug

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/efc5e53b695b