Closed
Bug 1420377
Opened 7 years ago
Closed 6 years ago
Avoid atomize 'is' value twice when the custom element is created from parser
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(1 file)
The duplicated atomizing is in * https://searchfox.org/mozilla-central/rev/a5d613086ab4d0578510aabe8653e58dc8d7e3e2/parser/html/nsHtml5TreeOperation.cpp#412 * https://searchfox.org/mozilla-central/rev/a5d613086ab4d0578510aabe8653e58dc8d7e3e2/dom/html/nsHTMLContentSink.cpp#263
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6acc85307f55d88d1a41878f94e2a2599302850e&filter-tier=1&group_state=expanded
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a089e759f2ab92795d69bd84fd96383aefea251&filter-tier=1&group_state=expanded
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c40fe67582418c897caed4e0c875b140f0445f6b&filter-tier=1&group_state=expanded
Assignee | ||
Updated•6 years ago
|
Attachment #8931632 -
Flags: review?(bugs)
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8931632 [details] Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser; https://reviewboard.mozilla.org/r/202804/#review218806 Btw, if there are some very hot code paths in main thread needing atomize, NS_AtomizeMainThread can be a bit faster, at least if it gets called often with same values. But I don't think any case here is such.
Attachment #8931632 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to Olli Pettay [:smaug] (please try to find other reviewers for non-web components patches) from comment #8) > Btw, if there are some very hot code paths in main thread needing atomize, > NS_AtomizeMainThread can be a bit faster, at least if it gets called often > with same values. Nice to learn this. Thank you. :)
Comment 10•6 years ago
|
||
Pushed by echen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/efc5e53b695b Avoid atomizing 'is' value twice when the custom element is created from parser; r=smaug
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efc5e53b695b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•