Avoid atomize 'is' value twice when the custom element is created from parser

RESOLVED FIXED in Firefox 59

Status

()

defect
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: edgar, Assigned: edgar)

Tracking

Trunk
mozilla59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

Attachment #8931632 - Flags: review?(bugs)
Comment on attachment 8931632 [details]
Bug 1420377 - Avoid atomizing 'is' value twice when the custom element is created from parser;

https://reviewboard.mozilla.org/r/202804/#review218806

Btw, if there are some very hot code paths in main thread needing atomize, NS_AtomizeMainThread can be a bit faster, at least if it gets called often with same values.
But I don't think any case here is such.
Attachment #8931632 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] (please try to find other reviewers for non-web components patches) from comment #8)
> Btw, if there are some very hot code paths in main thread needing atomize,
> NS_AtomizeMainThread can be a bit faster, at least if it gets called often
> with same values.

Nice to learn this. Thank you. :)
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efc5e53b695b
Avoid atomizing 'is' value twice when the custom element is created from parser; r=smaug
https://hg.mozilla.org/mozilla-central/rev/efc5e53b695b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.