1420414 - Update of the update.sh vorbis script

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

A few changes:
* +x on the script
* add the #!/bin/sh
* check the number of args
* readme has been renamed
* todo.txt no longer exits

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1420414 - Update of the update.sh vorbis script

* +x on the script
* add the #!/bin/sh
* check the number of args
* readme has been renamed
* todo.txt no longer exits

Review commit: https://reviewboard.mozilla.org/r/202832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202832/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1420414 - Remove libvorbis/todo.txt and rename README => README.md just like upstream

Review commit: https://reviewboard.mozilla.org/r/202834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/202834/

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8931671 [details]
Bug 1420414 - Update of the update.sh vorbis script

https://reviewboard.mozilla.org/r/202832/#review211530

Thanks for the clean-up!

::: media/libvorbis/update.sh:52
(Diff revision 1)
>  cp $1/lib/bitrate.c ./lib/vorbis_bitrate.c
>  cp $1/lib/block.c ./lib/vorbis_block.c
>  cp $1/include/vorbis/codec.h ./include/vorbis/codec.h
> -cp $1/todo.txt ./todo.txt
>  cp $1/COPYING ./COPYING
> -cp $1/README ./README
> +cp $1/README.md ./README

Might as well copy this as README.md. Just remember to remove the old file with updating.

Comment 4

[Ralph Giles (:rillian)]

Comment on attachment 8931672 [details]
Bug 1420414 - Remove libvorbis/todo.txt and rename README => README.md just like upstream

https://reviewboard.mozilla.org/r/202834/#review211532

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8931671 [details]
Bug 1420414 - Update of the update.sh vorbis script

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202832/diff/1-2/

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8931672 [details]
Bug 1420414 - Remove libvorbis/todo.txt and rename README => README.md just like upstream

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/202834/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9efca063d9ea
Update of the update.sh vorbis script r=rillian
https://hg.mozilla.org/integration/autoland/rev/db4e281855dc
Remove libvorbis/todo.txt and rename README => README.md just like upstream r=rillian

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9efca063d9ea
https://hg.mozilla.org/mozilla-central/rev/db4e281855dc