1420428 - Add search engine button and icon are displayed even if certain search engines are already installed

Status: RESOLVED DUPLICATE of bug 351441

(Firefox :: Search, defect)

Description

[Oana Botisan, Desktop QA]

Attachment: ScreenCapture_11-24-2017 4.59.17 PM.wmv

[Note]:
-

[Affected versions]:
- latest Nightly 59
- beta 58.0b6 - build1
- RC 57.0 - build 4
- RC 56.0.2

[Affected platforms]:
- Windows 10 x 64
- Windows 8.1 x32
- Ubuntu 16.04 x 64
- Mac OS 10.10

[Prerequisites]:
- Have the search bar activated on the toolbar. (about:preferences#search - select "Add search bar in toolbar")

[Steps to reproduce]:
1. Install Booking.com as a search engine from https://addons.mozilla.org/en-US/firefox/search/?type=search
2. Access the site: https://www.booking.com/
3. Notice that the magnifying glass icon has the symbol with the green cross and click on it.
4. Then click on "Add Booking.com Online Hotel Reservations"
5. An error should appear: " Firefox could not install the search plugin from “https://s-ec.bstatic.com/static/opensearch/en-us/e19e3ca297c466eb18e0b783736192a638f6a66e.xml” because an engine with the same name already exists."
6. Click "OK".

[Expected result]:
- The green cross disappears from the magnifying glass icon and the button "Add Booking.com Online Hotel Reservations" is not displayed.
 
[Actual result]:
- The green cross still appears on the magnifying glass icon and the button "Add Booking.com Online Hotel Reservations" is displayed.
 

[Regression range]:
- I'm not sure if this is a regression. We found a similar behaviour in 35.0a1 (2014-10-01), when the button for adding new search engine is displayed even if the green cross on the magnifying glass icon wasn't implemented. 

[Additional notes]:
- To understand better please look at the attached video.

Comment 1

[Mike Kaply [:mkaply]]

This happens because the title used in the opensearch description (Booking.com Online Hotel Reservations) is not the same as the title of the search engine (Booking.com)

You can see this working properly here:

https://developer.mozilla.org/en-US/

I believe this is a WONTFIX.

Comment 2

[Florian Quèze [:florian]]

The only way to fix this would be to download the XML file of the search plugin before showing the '+' badge in the searchbox, and do the duplication check based on the engine name included in the xml file, rather than the engine name given by the web page offering the plugin.

I'm sure we already discussed this in the past, and I think it didn't seem worth the effort. So I agree with wontfix. Although technically this is a duplicate of bug 351441 (that we can wontfix).