Closed
Bug 1420470
Opened 7 years ago
Closed 7 years ago
Remove for-each options from CompileOptions and JSCompartment
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
6.12 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8931740 -
Flags: review?(jorendorff)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8931740 [details] [diff] [review] bug1420470.patch Yes, thank you.
Attachment #8931740 -
Flags: review?(jorendorff) → review+
|
|
||
Updated•7 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8d63c3d55b0d98c53089e69aa3b80e648890bb
Keywords: checkin-needed
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/78cf58c01757 Remove for-each options from CompileOptions and from JSCompartment. r=jorendorff
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
Backed out for linux32 debug bustage in js/src/gc/Cell.h https://hg.mozilla.org/integration/mozilla-inbound/rev/78555431350c5d0d2909981f5400f20b6487984f Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3942ce38b1f62fbc3154e42281d31cbed1e81ce0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=149872761&repo=mozilla-inbound /builds/worker/workspace/build/src/js/src/gc/Cell.h:86:25: error: cannot call member function 'bool js::gc::Cell::is() const [with T = FakeNode]' without object
Flags: needinfo?(andrebargull)
|
|
Assignee | |
Comment 6•7 years ago
|
||
The compiler error doesn't seem to be reproducible (`try: -b d -p linux -u none -t none`): https://treeherder.mozilla.org/#/jobs?repo=try&revision=55626e20b6ed01dd0c6bb21a30c370b118e5cf52 https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6af4e26f0ec9d73b481a247211f39a52d2b9e3d https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5cd5ed75a2b6e9a30abcc9727960f92e78b1e05 So it was either a one-time error or some kind of intermittent compiler issue which could resurface again in the future.
Flags: needinfo?(andrebargull)
|
|
Assignee | |
Comment 7•7 years ago
|
||
The build error doesn't seem to be reproducible (comment #6), so let's try this one again.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad7d9c26ed51 Remove for-each options from CompileOptions and from JSCompartment. r=jorendorff
Keywords: checkin-needed
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad7d9c26ed51
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•