Closed Bug 14205 Opened 25 years ago Closed 25 years ago

[MLK] XUL overlays cause XULDocumentImpl to leak

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: waterson, Assigned: waterson)

Details

Attachments

(2 files)

main.xul
398 bytes, text/xul
Details
overlay.xul
353 bytes, text/xul
Details 
Including a XUL overlay appears to be causing the including document to leak.
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: M11
Marking P1/M11 because this screws up persistence and will bleed a boatload of
memory.
Attached file main.xul — 

    
    

    
  

      
      
      
      

        Attached file
          
        overlay.xul
        — 
      

    


  

    
    

    
  
To reproduce:

1. Download "main.xul" & "overlay.xul", save as local files.
2. Run viewer.
3. Set a breakpoint in XULDocumentImpl::~XULDocumentImpl
4. Open "main.xul"
5. Click "Back"
6. Note that breakpoint never hits

Now...

7. Commend out "xul-overlay" processing directive in main.xul
8. Repeat steps 4 & 5
9. See breakpoint hit.

Leak! Whee!

    
  
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED

    
    

    
  
Marking this fixed, as test case works. Opened bug 14291 because we still leak
when you open navigator.xul.

    
  
QA Contact: ckritzer → waterson

    
    

    
  
Assigning to originator per new organizational structure.

    
  
QA Contact: waterson → ckritzer

    
    

    
  
Changing QA Contact back to ckritzer@netscape.com

    
  
Status: RESOLVED → VERIFIED

    
    

    
  
rubberstamping verified, this looks fixed

    
    

    
  
BULK MOVE: Changing component from XUL to XP Toolkit/Widgets: XUL.  XUL 
component will be deleted.
Component: XUL → XP Toolkit/Widgets: XUL

    
  
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: ckritzer → xptoolkit.widgets

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: