Closed
Bug 1420516
Opened 7 years ago
Closed 7 years ago
Remove ScrollDirection::NONE
Categories
(Core :: Panning and Zooming, enhancement)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(1 file)
Splitting this out from bug 951793.
Removing ScrollDirection::NONE allows us to be more precise about whether or not "no scroll direction" is a valid value for a variable. In cases where it is, Maybe<ScrollDirection> is used as the variable's type.
It also facilitates using an EnumSet<ScrollDirection> to represent a set of allowed scroll directions.
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8931786 [details]
Bug 1420516 - Remove ScrollDirection::NONE.
https://reviewboard.mozilla.org/r/202918/#review208232
Attachment #8931786 -
Flags: review?(bugmail) → review+
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81d3e4a2f3f3
Remove ScrollDirection::NONE. r=kats
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•