Closed Bug 1420516 Opened 2 years ago Closed 2 years ago

Remove ScrollDirection::NONE

Categories

(Core :: Panning and Zooming, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: botond, Assigned: botond)

References

Details

Attachments

(1 file)

Splitting this out from bug 951793.

Removing ScrollDirection::NONE allows us to be more precise about whether or not "no scroll direction" is a valid value for a variable. In cases where it is, Maybe<ScrollDirection> is used as the variable's type.

It also facilitates using an EnumSet<ScrollDirection> to represent a set of allowed scroll directions.
Blocks: 951793, 1418387
Comment on attachment 8931786 [details]
Bug 1420516 - Remove ScrollDirection::NONE.

https://reviewboard.mozilla.org/r/202918/#review208232
Attachment #8931786 - Flags: review?(bugmail) → review+
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/81d3e4a2f3f3
Remove ScrollDirection::NONE. r=kats
https://hg.mozilla.org/mozilla-central/rev/81d3e4a2f3f3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Depends on: 1462370
You need to log in before you can comment on or make changes to this bug.