1420580 - Add DOMMatrix/DOMPoint, etc. support in web workers

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect, P3)

Description

[Jeroen Hoek]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171115095126

Steps to reproduce:

Tried to use DOMMatrix in a web worker thread (new DOMMatrix([m11, …])).


Actual results:

Got 'ReferenceError: DOMMatrix is not defined' in the worker thread.


Expected results:

If I interpret the specs correctly, DOMMatrix should be exposed to both Window and Worker. Because DOMMatrix can be used for transformation computations as used in image manipulation, it seems like a good candidate for use in web workers to perform such calculations without blocking the user interface.

https://drafts.fxtf.org/geometry/#DOMMatrix

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1420580: Expose Geometry Interfaces to worker

Exposes DOMMatrix, DOMPoint, DOMQuad, and DOMRect to workers.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

I can't add checkin-needed, could you add it? Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3e4205698b8
Expose Geometry Interfaces to worker r=bzbarsky

Comment 4

[Boris Zbarsky [:bzbarsky]]

I can do better: I can just schedule the landing. Which I did. ;)

Do you want to send an intent-to-ship email for this, per https://wiki.mozilla.org/ExposureGuidelines#Intent_to_ship? If not, I can do it; just let me know.

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Just re-sent it and now waiting an approval. (I sent one a few days back without subscribing the mailing list, and looks like it didn't work.)

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK. If it doesn't come through soon, please let me know!

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fwiw, there were test failures not caught by the try push mentioned in phabricator, because there are non-web-platform tests for some of this stuff. Bug 1559638 tracks and I will fix.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a3e4205698b8

Comment 10

[Eric Shepherd [:sheppy]]

Documentation updated:

• Submitted BCD PR 4823 to update the compatibility data for the affected methods.

Please advise if there are any remaining issues with the content affected here.

Comment 11

[Eric Shepherd [:sheppy]]

OK, returning to dev-doc-needed status; this isn't just about DOMMatrix. I need to update DOMPoint, DOMRect, and DOMQuad. Will do that Monday.