Closed Bug 1420580 Opened 6 years ago Closed 4 years ago

Add DOMMatrix/DOMPoint, etc. support in web workers

Categories

(Core :: DOM: Workers, defect, P3)

Product:
Core
Component:
DOM: Workers
Version:
57 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mail, Assigned: saschanaz)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1420580: Expose Geometry Interfaces to worker
47 bytes, text/x-phabricator-request
Details | Review 
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171115095126

Steps to reproduce:

Tried to use DOMMatrix in a web worker thread (new DOMMatrix([m11, …])).


Actual results:

Got 'ReferenceError: DOMMatrix is not defined' in the worker thread.


Expected results:

If I interpret the specs correctly, DOMMatrix should be exposed to both Window and Worker. Because DOMMatrix can be used for transformation computations as used in image manipulation, it seems like a good candidate for use in web workers to perform such calculations without blocking the user interface.

https://drafts.fxtf.org/geometry/#DOMMatrix
Component: Untriaged → DOM: Workers
Product: Firefox → Core
Priority: -- → P3

Exposes DOMMatrix, DOMPoint, DOMQuad, and DOMRect to workers.

Status: UNCONFIRMED → NEW
Ever confirmed: true

I can't add checkin-needed, could you add it? Thanks!

Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3e4205698b8
Expose Geometry Interfaces to worker r=bzbarsky

I can do better: I can just schedule the landing. Which I did. ;)

Do you want to send an intent-to-ship email for this, per https://wiki.mozilla.org/ExposureGuidelines#Intent_to_ship? If not, I can do it; just let me know.

Flags: needinfo?(bzbarsky)

Just re-sent it and now waiting an approval. (I sent one a few days back without subscribing the mailing list, and looks like it didn't work.)

OK. If it doesn't come through soon, please let me know!

Fwiw, there were test failures not caught by the try push mentioned in phabricator, because there are non-web-platform tests for some of this stuff. Bug 1559638 tracks and I will fix.

Regressions: 1559638

https://hg.mozilla.org/mozilla-central/rev/a3e4205698b8

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → saschanaz

Documentation updated:

  • Submitted BCD PR 4823 to update the compatibility data for the affected methods.

Please advise if there are any remaining issues with the content affected here.

Keywords: dev-doc-needed → dev-doc-complete

OK, returning to dev-doc-needed status; this isn't just about DOMMatrix. I need to update DOMPoint, DOMRect, and DOMQuad. Will do that Monday.

Keywords: dev-doc-complete → dev-doc-needed
You need to log in before you can comment on or make changes to this bug.