1420583 - Regression: After resetting the Theme Settings to Default, the NewTab button keeps placed at the very right side

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mehmet]

Attachment: NewTabButton_Issue.mov

macOS 10.12.6 - but probably OS=All
59.0a1 (2017-11-25) (64-Bit)

1.) Open the Theme Customizing
2.) Make a change
3.) Reset the settings to Default
4.) Close the Theme Customizing

Actual: The NewTabButton keeps placed at the right side of the Tabbar.

Expected: It should be placed next to the last Tab.

A screencast is attached.

This is a regression.

Comment 1

[Mehmet]

Here is the regression range:

Good: 2017-11-23-22-01-10

 Bad: 2017-11-24-10-05-00

Maybe https://hg.mozilla.org/mozilla-central/rev/1490a930ccea ?

+Gijs: Can you please take a look?

Thanks.

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1420583 - fix new tab adjacency logic when using "restore defaults",

When using "restore defaults", Customize mode unwraps all elements. The previous implementation
of _updateNewTabVisibility assumed that elements were wrapped in <toolbarpaletteitem>s when in
customize mode, but this isn't true during a reset. The new implementation just looks for the
<toolbarpaletteitem>s and their children as necessary.

Review commit: https://reviewboard.mozilla.org/r/203148/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203148/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8932103 [details]
Bug 1420583 - fix new tab adjacency logic when using "restore defaults",

https://reviewboard.mozilla.org/r/203148/#review208546

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08555b236fa7
fix new tab adjacency logic when using "restore defaults", r=jaws

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/08555b236fa7

Comment 6

[:Gijs (he/him)]

Mehmet, can you verify this is now fixed on nightly and/or if you can break where the new tab button shows up some other way? Thanks!

Comment 7

[Mehmet]

(In reply to :Gijs from comment #6)
> Mehmet, can you verify this is now fixed on nightly and/or if you can break
> where the new tab button shows up some other way? Thanks!

Can no longer reproduce it - Looks fixed to me in 59.0a1 (2017-11-28) (64-Bit).

Thank you!

Comment 8

[:Gijs (he/him)]

Marking verified per comment #7, thanks!

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5be79b1b3deb