Created attachment 8931915 [details] [diff] [review] addr_info.patch This patch depends on the patch I submitted for Bug 1420673. I can switch the order pretty easily. I'm not sure how to make MozReview work with stacked patches and stacked bugs (I got the error "abort: cannot submit reviews referencing multiple bugs"), so I'm just submitting this the old-fashioned way. Hopefully after we convert these over we'll be able to land Bug 1403802 without any memory leak complaints.
Attachment #8931915 - Flags: review?(valentin.gosu)
Err, I mean we'll be able to land Bug 1417827.
(In reply to jthemphill from comment #2) > Err, I mean we'll be able to land Bug 1417827. Does your push include the patch from Bug 1417827? Just to confirm that the leak was actually caused by this?
Assignee: nobody → jthemphill
Yep! The tryserver commit hash for my push is d822df2aa260. You can see the `NSCString`s here: https://hg.mozilla.org/try/file/d822df2aa2608cdeb34d1f6a1a7893247daefccb/netwerk/dns/DNS.h#l153
Comment on attachment 8931915 [details] [diff] [review] addr_info.patch Review of attachment 8931915 [details] [diff] [review]: ----------------------------------------------------------------- You can submit individual patches for review by doing `hg push review -c <changeset_id>`
Attachment #8931915 - Flags: review?(valentin.gosu) → review+
This can be checked in once the patch for Bug 1420673 is checked in.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/27719294cb73 Convert nsHostResolver.addr_info to a UniquePtr. r=valentin
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Okay, I guess the memory leak was here: https://hg.mozilla.org/integration/mozilla-inbound/file/tip/netwerk/dns/nsHostResolver.cpp#l873 The leak occurred because we had set the pointer to null but didn't free the underlying data. Now that we're using UniquePtr, we're good to go!
That seems to be the case. Anyway, thanks for working on all these patches! It's proved to be very useful.
You need to log in before you can comment on or make changes to this bug.