1420706 - TEST-UNEXPECTED-FAIL | comm/mail/components/test/unit/test_about_support.js on TaskCluster

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | comm/mail/components/test/unit/test_about_support.js.

Linux 32 only.

Comment 1

[:aceman]

TOm, can you check if GConf service/package is properly installed on the TC server for Linux 32?

The failure is:
WARNING -  TEST-UNEXPECTED-FAIL | comm/mail/components/test/unit/test_about_support.js | xpcshell return code: 0
 INFO -  TEST-INFO took 136ms
  INFO -  >>>>>>>
   INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
   INFO -  NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]
   INFO -  run_test@/builds/worker/workspace/build/tests/xpcshell/tests/comm/mail/components/test/unit/test_about_support.js:189:5

The failing code is:
  if ("@mozilla.org/gnome-gconf-service;1" in Cc) {
    // The GNOME GConf service needs to be initialized, otherwise we get
    // assertions about g_type_init not being called.
    Cc["@mozilla.org/gnome-gconf-service;1"].getService();  // line 189
  }

So the code "thinks" gconf is available (it was included in CC due to some checks), but we can't get it via getService. So the gconf is detected but not properly working/gettable.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1420706: Remove obsolete gconf work-around.

The check was added https://bugzilla.mozilla.org/show_bug.cgi?id=628204#c8
without discussion or motivation, other than making the test pass.  I suspect
it was to work around a bug with the gconf support in gecko, which has probably
since been fixed or made irrelevant.

Review commit: https://reviewboard.mozilla.org/r/208168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/208168/

Comment 3

[:aceman]

Comment on attachment 8937495 [details]
Bug 1420706: Remove obsolete gconf work-around.

https://reviewboard.mozilla.org/r/208168/#review213952

Thanks! I can't test it locally right now, but it passes on try TC (https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=c7117a49f2632bb00c4e71b571fead428bceabb7).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7d31bdf07253
Remove obsolete gconf work-around; r=aceman