1420720 - Crash in mozilla::net::nsHttpTransaction::HandleContent

Status: RESOLVED WORKSFORME

(Core :: Networking: HTTP, defect, P3)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is
report bp-6b8fd966-91c2-4fb7-9700-8cad80171116.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll mozilla::net::nsHttpTransaction::HandleContent netwerk/protocol/http/nsHttpTransaction.cpp:1686
1 xul.dll mozilla::net::nsHttpTransaction::ProcessData netwerk/protocol/http/nsHttpTransaction.cpp:1822
2 xul.dll mozilla::net::nsHttpTransaction::WritePipeSegment netwerk/protocol/http/nsHttpTransaction.cpp:838
3 xul.dll nsPipeOutputStream::WriteSegments xpcom/io/nsPipe3.cpp:1835
4 xul.dll mozilla::net::nsHttpTransaction::WriteSegments netwerk/protocol/http/nsHttpTransaction.cpp:924
5 xul.dll mozilla::net::Http2Stream::WriteSegments netwerk/protocol/http/Http2Stream.cpp:308
6 xul.dll mozilla::net::Http2Session::WriteSegmentsAgain netwerk/protocol/http/Http2Session.cpp:3213
7 xul.dll mozilla::net::nsHttpConnection::OnSocketReadable netwerk/protocol/http/nsHttpConnection.cpp:1912
8 xul.dll mozilla::net::nsHttpConnection::OnInputStreamReady netwerk/protocol/http/nsHttpConnection.cpp:2249
9 xul.dll mozilla::net::nsSocketInputStream::OnSocketReady netwerk/base/nsSocketTransport2.cpp:298

=============================================================

this cross-platform crash signature has been around for a while already. it may be slightly on the increase with firefox 57.
many user comments mention they were interacting with twitter at the time of the crash.

Comment 1

[Michal Novotny [:michal]]

mConnection is probably null in nsHttpTransaction::HandleContent. I don't know who knows this code best. Honza, can you have a look at it?

Comment 2

[Honza Bambas (:mayhemer)]

Yeah, but leave it unassigned for now.  I won't have time immediately to take this.  Unless this is a high volume crash.

Comment 3

[Patrick McManus [:mcmanus]]

mconnection really shouldn't be null there - (tho I'm sure michal is right and it is).. the function even asserts it.

I wonder if this is a dup of the problem dd found when looking at 425 (which is a long standing problem with 421) - restartTransaction is one way to null out that pointer.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.