1420774 - Drop virtual from some Animation methods

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

virtual Promise* GetFinished(ErrorResult& aRv);
virtual void Finish(ErrorResult& aRv);
virtual void Reverse(ErrorResult& aRv);

These methods are not overridden at all.

GetFinish() should be perhaps overridden since it might need to flush style as GetReady() does, but if so I will fix it in a followup bug.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1420774 - Drop unnecessary virtual from Animation methods.

Review commit: https://reviewboard.mozilla.org/r/203042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203042/

Comment 2

[Boris Chiou [:boris]]

Comment on attachment 8931984 [details]
Bug 1420774 - Drop unnecessary virtual from Animation methods.

https://reviewboard.mozilla.org/r/203042/#review208350

CSSAnimation and CSSTransition doesn't override these functions. Looks good.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c259d35fa9f
Drop unnecessary virtual from Animation methods. r=boris

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/4c259d35fa9f