1420798 - Apply the ProofOfLock pattern to MediaCache

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

MediaCache::Foo()
{
  mReentrantMonitor.AssertCurrentThreadIn();
}

MediaCache::Bar()
{
  ReentrantMonitorAutoEnter mon(mReentrantMonitor);
  Foo();
}

can be replaced by

MediaCache::Foo(ReentrantMonitorAutoEnter& aLock)
{
}

MediaCache::Bar()
{
  ReentrantMonitorAutoEnter mon(mReentrantMonitor);
  Foo(mon);
}

This allows us to replace ReentrantMonitor with Monitor in the future.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1420798 - apply the 'ProofOfLock' pattern to MediaCache.

See comment 0 for the detail.

We will replace ReentrantMonitor with Monitor in the future.

Review commit: https://reviewboard.mozilla.org/r/203326/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203326/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8932295 [details]
Bug 1420798 - apply the 'ProofOfLock' pattern to MediaCache.

https://reviewboard.mozilla.org/r/203326/#review208708

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8932295 [details]
Bug 1420798 - apply the 'ProofOfLock' pattern to MediaCache.

https://reviewboard.mozilla.org/r/203326/#review208738

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the reviews!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bafd5fe6a059
apply the 'ProofOfLock' pattern to MediaCache. r=bechen,gerald

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bafd5fe6a059