1420820 - Enable window manager detection/setup override

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

We may need to provide a way to override window manager default config. It will help people to experiment and also easily test systems we don't have config for.

Comment 1

[Marco Castelluccio [:marco]]

We could add a pref for overriding it.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

(In reply to Marco Castelluccio [:marco] from comment #1)
> We could add a pref for overriding it.

I tend to use env variable here as we also want to override an env variable (XDG_CURRENT_DESKTOP).

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1420820 - Added MOZ_GTK_TITLEBAR_DECORATION to override window manager detection and set window decoration type,

Enables override window manager default with those values:

MOZ_GTK_TITLEBAR_DECORATION=none - Firefox does not mess with decoration
MOZ_GTK_TITLEBAR_DECORATION=client - Firefox tries to disable titlebar rendering and draws shadows by client side decorations.
MOZ_GTK_TITLEBAR_DECORATION=system - Firefox tries to disable titlebar rendering and leave system (window manager) to draw window decorations.

Review commit: https://reviewboard.mozilla.org/r/205108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/205108/

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 8934165 [details]
Bug 1420820 - Added MOZ_GTK_TITLEBAR_DECORATION to override window manager detection and set window decoration type,

https://reviewboard.mozilla.org/r/205108/#review210600

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b43214fcdc
Added MOZ_GTK_TITLEBAR_DECORATION to override window manager detection and set window decoration type, r=jhorak

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b9b43214fcdc