Ensure only fields valid for the given country are saved

VERIFIED FIXED in Firefox 64

Status

()

defect
P1
normal
VERIFIED FIXED
a year ago
6 months ago

People

(Reporter: scottwu, Assigned: jaws)

Tracking

(Blocks 2 bugs)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 verified)

Details

(Whiteboard: [webpayments] [form autofill:V2])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
For countries like Germany, which doesn't fill address-level1 (province), there's a chance we'd inadvertently populate address-level1 if the field is not empty.

STR:
1. Set country to US
2. Fill the State field
3. Change country to Germany
4. Save address

The hidden address-level1 field (previously State) probably shouldn't be saved as part of a German address.
(Reporter)

Updated

a year ago
Whiteboard: [form autofill:V2]
(Reporter)

Updated

a year ago
Assignee: nobody → scwwu
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8942597 [details]
Bug 1420853 - Ensure only fields valid for the given country are saved.

https://reviewboard.mozilla.org/r/212862/#review219138
Attachment #8942597 - Flags: review?(lchang) → review+
Whiteboard: [form autofill:V2] → [form autofill:V2] [webpayments]

Updated

11 months ago
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [form autofill:V2] [webpayments] → [form autofill:V2] [webpayments-reserve]

Comment 3

9 months ago
Another issue worth to mention that could be handled here:

Editing an already saved address from DE to US populate the state field automatically
STR:
1. Go to "https://rsolomakhin.github.io/pr/single/" and click on "Buy" button.
2. Edit an already saved shipping address country from US to DE.
3. Edit the same shipping address and change the country again from DE to US.
Assignee: scottcwwu → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Whiteboard: [form autofill:V2] [webpayments-reserve] → [webpayments-reserve] [form autofill:V2]
Flags: qe-verify?
Priority: P3 → P2
Whiteboard: [webpayments-reserve] [form autofill:V2] → [webpayments] [form autofill:V2]
Flags: qe-verify? → qe-verify+
QA Contact: hani.yacoub
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P2 → P1
This patch is a completion of the work done by Scott Wu.

Comment 5

6 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95fe4f9c3203
Ensure only fields valid for the given country are saved. r=MattN

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/95fe4f9c3203
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64

Comment 7

6 months ago
Verified as fixed on Firefox Nightly 64.0a1 (2018-10-22) on Windows 10 x 64, Windows 7 x32, Mac OS X 10.13 and on Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.