Closed Bug 1420883 Opened 2 years ago Closed 2 years ago

Modal windows with saved addresses card do not accommodate to content size

Categories

(Toolkit :: Form Autofill, defect)

57 Branch
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla59
Tracking Status
firefox59 --- verified

People

(Reporter: mstanke, Assigned: scottwu)

References

(Blocks 2 open bugs)

Details

Attachments

(4 files)

STR:
1. With Czech (cs) Nightly, open about:preferences > Privacy & Security.
2. Click the button to see the list of saved addresses or cards.
3. See the modal windows contain unnecessary scrollbars (adding overflow:hidden to the element does not hide any content).

Seems like bug 1390828 is still there.

Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171126220311
Component: Form Manager → Form Autofill
I tried it on my Ubuntu but couldn't reproduce this bug.
Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171127220446

Could you attach a screenshot of what you saw? Thanks!
Flags: needinfo?(mstanke)
Attached image Scollbar_issue.png
The other issue happens about scroll bar, which may be related to this bug.
Attached image screenshot
This is how it looks for me with Nightly 59 (tar.gz from Mozilla.org) and Fedora 27.
Flags: needinfo?(mstanke)
Assignee: nobody → scwwu
Status: NEW → ASSIGNED
Comment on attachment 8932350 [details]
Bug 1420883 - Change setting width to min-width for manage addresses dialog.

https://reviewboard.mozilla.org/r/203390/#review209690

The patch itself looks good but we may need to make sure it fixed the issue on Czech Nightly as well.
Attachment #8932350 - Flags: review?(lchang) → review+
I've tested with CZ locale on my Mac and the issue has been fixed with this patch. However I couldn't reproduce it on my Linux environment so I can't be 100% sure, but I'm pretty confident it's been resolved there as well.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a5fce9a1e5c1
Change setting width to min-width for manage addresses dialog. r=lchang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5fce9a1e5c1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
I can verify the scrollbars are gone in Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171204234137. There is an unnecessary disabled scrollbar shown for the list of cards itself, if there is only one card in the list, but that is a different bug I will report later.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.