1420925 - Some JS module error test cases concerning error identity are outdated

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Jon Coppeard (:jonco)]

Created for this issue: https://github.com/w3c/web-platform-tests/issues/7747

When bug 1420420 lands a few tests will start to fail until they are updated to match the latest spec.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1420925-update-error-identity-tests

Update module tests that checked the identity of instantiation exceptions to check the message instead.

The instantiation-error-3.html test often fails in our implementation for other reasons so I disabled this.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8937166 [details] [diff] [review]
bug1420925-update-error-identity-tests

Speculative r? jgraham.  Feel free to reject and I'll find someone else.

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8937166 [details] [diff] [review]
bug1420925-update-error-identity-tests

Review of attachment 8937166 [details] [diff] [review]:
-----------------------------------------------------------------

I'm slightly guessing that the test changes are OK, but it seems reasonable.

::: testing/web-platform/meta/html/semantics/scripting-1/the-script-element/module/instantiation-error-3.html.ini
@@ +1,2 @@
>  [instantiation-error-3.html]
> +  disabled: often fails

Usually we link this to a bug number

Comment 4

[Jon Coppeard (:jonco)]

I filed bug 1426195 for the instantiation-error-3.html failures.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9928b5dffb3f
Update JS module tests now that repeated instantiation failures of a module are no longer required to throw the same value r=jgraham

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9928b5dffb3f