1420974 - API to open bookmarks in new tab

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Mike Conca [:mconca]]

Add a WebExtension API to determine if bookmarks should be opened in the current page or a new tab.  This basically exposes the browser.tabs.loadBookmarksInTabs preference.

This option was popular with Tab Mix Plus users and the China repack of Firefox.

Comment 1

[Andy McKay]

Bob, could we look at landing an API for this please?

Comment 2

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1420974 - API to open bookmarks in new tab,

This introduces browserSettings.openBookmarksInNewTabs which exposes
the browser.tabs.loadBookmarksInTabs preference to extensions.

Review commit: https://reviewboard.mozilla.org/r/203508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203508/

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8932469 [details]
Bug 1420974 - API to open bookmarks in new tab,

https://reviewboard.mozilla.org/r/203508/#review209100

::: toolkit/components/extensions/schemas/browser_settings.json:65
(Diff revision 1)
>          "$ref": "types.Setting",
>          "description": "Returns the value of the overridden new tab page. Read-only."
>        },
> -      "contextMenuShowEvent": {
> +      "openBookmarksInNewTabs": {
>          "$ref": "types.Setting",
> -        "description": "Controls after which mouse event context menus popup. This setting's value is of type ContextMenuMouseEvent, which has possible values of <code>mouseup</code> and <code>mousedown</code>."
> +        "description": "Controls whether bookmarks are opened in the current tab or in a new tab."

Might be nice to mention it's a boolean.  Side note, how are types validated here?

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8932469 [details]
Bug 1420974 - API to open bookmarks in new tab,

https://reviewboard.mozilla.org/r/203508/#review209100

> Might be nice to mention it's a boolean.  Side note, how are types validated here?

Types are not validated for either the privacy or the browserSettings APIs. This is probably something we should fix, but I'm not sure how to go about doing that.

Comment 5

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8932469 [details]
Bug 1420974 - API to open bookmarks in new tab,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203508/diff/1-2/

Comment 6

[Bob Silverberg [:bsilverberg]]

(In reply to Bob Silverberg [:bsilverberg] from comment #4)
> Comment on attachment 8932469 [details]
> Bug 1420974 - API to open bookmarks in new tab,
> 
> https://reviewboard.mozilla.org/r/203508/#review209100
> 
> > Might be nice to mention it's a boolean.  Side note, how are types validated here?
> 
> Types are not validated for either the privacy or the browserSettings APIs.
> This is probably something we should fix, but I'm not sure how to go about
> doing that.

I opened bug 1421648 to discuss this issue.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a46e18c726d
API to open bookmarks in new tab, r=mixedpuppy

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5a46e18c726d

Comment 9

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 10

[Will Bamberg [:wbamberg]]

-> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browserSettings/openBookmarksInNewTabs

Please let me know if this covers it (note that the compat data is not deployed to MDN yet, but will be soon).

Comment 11

[Bob Silverberg [:bsilverberg]]

Looks good, thanks Will.