1421038 - Rename 'relativedir' to 'relsrcdir'

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1319222#c12 -

We should rename 'relativedir' in ContextDerived so it is no longer ambiguous whether it is relative to the srcdir or objdir. In the Context we use 'relsrcdir', so let's switch to that.

Comment 1

[(not currently active) Ted Mielczarek]

The recursive make backend calls this "relativesrcdir" and sets that for Makefiles to use FYI:
https://dxr.mozilla.org/mozilla-central/rev/da90245d47b17c750560dedb5cbe1973181166e3/python/mozbuild/mozbuild/backend/recursivemake.py#1593

That comes from the backend base _get_preprocessor method:
https://dxr.mozilla.org/mozilla-central/rev/da90245d47b17c750560dedb5cbe1973181166e3/python/mozbuild/mozbuild/backend/base.py#261

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1421038 - Rename 'relativedir' to 'relsrcdir';

The name 'relativedir' is ambiguous - it is unclear whether it is a
relative srcdir or objdir. Rename it to 'relsrcdir' in the
ContextDerived() object to match the naming used in Context() so it is
obvious that it is a relative srcdir.

Most of these are a straight text replacement from relativedir to
relsrcdir, except for tup.py:_get_backend_file(), which was supposed to
be using an objdir in the first place.

Review commit: https://reviewboard.mozilla.org/r/206404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206404/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8935503 [details]
Bug 1421038 - Rename 'relativedir' to 'relsrcdir';

https://reviewboard.mozilla.org/r/206404/#review212032

Yes please!  I remember this being surprising a while back.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/271c923ff4f6
Rename 'relativedir' to 'relsrcdir'; r=nalexander

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/271c923ff4f6