Closed Bug 1421038 Opened 2 years ago Closed 2 years ago

Rename 'relativedir' to 'relsrcdir'

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(1 file)

From https://bugzilla.mozilla.org/show_bug.cgi?id=1319222#c12 -

We should rename 'relativedir' in ContextDerived so it is no longer ambiguous whether it is relative to the srcdir or objdir. In the Context we use 'relsrcdir', so let's switch to that.
Assignee: nobody → mshal
Comment on attachment 8935503 [details]
Bug 1421038 - Rename 'relativedir' to 'relsrcdir';

https://reviewboard.mozilla.org/r/206404/#review212032

Yes please!  I remember this being surprising a while back.
Attachment #8935503 - Flags: review+
Attachment #8935503 - Flags: review?(core-build-config-reviews)
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/271c923ff4f6
Rename 'relativedir' to 'relsrcdir'; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/271c923ff4f6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.