Closed Bug 1421056 Opened 2 years ago Closed 2 years ago

Changes to the js Rust crate needed for Starling

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

Details

Attachments

(1 file, 2 obsolete files)

Changes include: whitelisting more things in `bindgen`, exposing the builtin
micro-task queue, and more conversion implementations.
Assignee: nobody → nfitzgerald
Changes include: whitelisting more things in `bindgen`, exposing the builtin
micro-task queue, and more conversion implementations.
Attachment #8932230 - Flags: review?(till)
Attachment #8932226 - Attachment is obsolete: true
Attachment #8932226 - Flags: review?(till)
Comment on attachment 8932230 [details] [diff] [review]
Changes to the js Rust crate needed for Starling

Review of attachment 8932230 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with or without the self-hosting stuff mentioned below changed

::: js/rust/src/rust.rs
@@ +1140,5 @@
> +            selfHostedName: 0 as *const _,
> +        }
> +    }
> +
> +    pub fn js_selfhosted_fn(name: *const ::std::os::raw::c_char,

Do we need to expose this? We currently don't have a way to add new self-hosted functions for the embedding anyway.

@@ +1195,5 @@
> +            }
> +        }
> +    }
> +
> +    pub fn getter_selfhosted(name: *const ::std::os::raw::c_char, flags: u8,

Same for this

@@ +1248,5 @@
> +            }
> +        }
> +    }
> +
> +    pub fn getter_setter_selfhosted(name: *const ::std::os::raw::c_char,

And this
Attachment #8932230 - Flags: review?(till) → review+
Removed self-hosted bits per review comments.
Attachment #8932278 - Flags: review+
Attachment #8932230 - Attachment is obsolete: true
Thanks for speedy review, Till!
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd70c8874a80
Changes to the js Rust crate needed for Starling. r=till
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bd70c8874a80
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.