1421107 - Stop the Performance tab from wrapping at narrower widths

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Jonathan French (:jfrench)]

The Performance tab for talos jobs appears to be wrapping at modest browser widths, when it shouldn't. I'll attach a screen grab.

If I recall way back when, I think we had some dynamic percentage control which calculated the max width of the parent container which prevented this. Perhaps it regressed with the bs4 upgrade.

Comment 1

[Jonathan French (:jfrench)]

Attachment: performanceTabWrap

Per screen grab.

Comment 2

[Jonathan French (:jfrench)]

(In reply to Jonathan French (:jfrench) from comment #0)
> If I recall way back when, I think we had some dynamic percentage control
> which calculated the max width of the parent container which prevented this.
> Perhaps it regressed with the bs4 upgrade.

This was that prior functionality
https://github.com/mozilla/treeherder/pull/1002

Comment 3

[Jonathan French (:jfrench)]

And looks like the dynamic width control got removed in this change (ui/plugins/pluginpanel.html L-227)
https://github.com/mozilla/treeherder/commit/f6258bf4d55a7763b17c3efb58f627e7d8751589

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3012

Comment 5

[Jonathan French (:jfrench)]

Comment on attachment 8933918 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3012

For review at your leisure :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2c3b9b7370581486ed47d3a37fd9de9e624468ea
Bug 1421107 - Stop perf tab wrapping at narrower widths