1421116 - Wait for the next event tick before resolving promise in browser_translation_exceptions.js.

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5800bb624450f22893e4918d653b3dbe231c4ac&selectedJob=147752981
> FAIL | browser/components/translation/test/browser_translation_exceptions.js | The language exceptions list has 2 items
> Got 0, expected 2 Stack trace: chrome://mochikit/content/browser-test.js:test_is:1269 chrome://mochitests/content/browser/browser/components/translation/test/browser_translation_exceptions.js:checkLanguageExceptions:230

after fixing bug 1193394, the test needs to wait for the next event tick before resolving promise in popupshown and load events, to make sure everything gets ready.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Wait for the next event tick before resolving promise in browser_translation_exceptions.js.

openPopup and waitForWindowLoad should wait for the next event tick before resolving the promise inside popupshwon/load event handler,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1dde9d5f00d
Wait for the next event tick before resolving promise in browser_translation_exceptions.js. r=Mossop

Comment 3

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1dde9d5f00d8de64a5fadb1bee0ccb97e0140c8
Bug 1421116 - Wait for the next event tick before resolving promise in browser_translation_exceptions.js. r=Mossop

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e23e0f1c6cb4
Backed out changeset e1dde9d5f00d for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s  r=backout on a CLOSED TREE

Comment 5

[Andreea Pavel [:apavel]]

Backed out changeset 56343b0de5c2 (bug 1424083) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1c819b56fe973b077d64737db186b066850e1197

Failure log: https://hg.mozilla.org/integration/mozilla-inbound/rev/a73f5a62f971efb9afa3b2e70b5d01b447ba3ed3

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a73f5a62f971efb9afa3b2e70b5d01b447ba3ed3

Comment 6

[Andreea Pavel [:apavel]]

Sorry, for the above comment, the right backout is: https://hg.mozilla.org/integration/mozilla-inbound/rev/e23e0f1c6cb4407c7e9209325908bec834b24f96

Comment 7

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc9d268b900e697bb079eef61ad373342ed55ff4
Bug 1421116 - Wait for the next event tick before resolving promise in browser_translation_exceptions.js. r=Mossop

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc9d268b900e