1421118 - Wait for the next event tick before resolving promise in preferences test.

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5800bb624450f22893e4918d653b3dbe231c4ac&selectedJob=147752924
> TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_cookies_exceptions.js | site should be sorted. 'z' should be first - Got http://a, expected http://z

after fixing bug 1193394, the test needs to wait for the next event tick before resolving promise in dialogopen event, to make sure everything gets ready.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Wait for the next event tick before resolving promise in preferences test.

promiseLoadSubDialog should wait for the next event tick before resolving the promise inside dialogopen event handler,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8932841 [details] [diff] [review]
Wait for the next event tick before resolving promise in preferences test.

Review of attachment 8932841 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/tests/head.js
@@ +66,5 @@
>          }
>        }
>        is(expectedStyleSheetURLs.length, 0, "All expectedStyleSheetURLs should have been found");
>  
> +      executeSoon(() => resolve(aEvent.detail.dialog._frame.contentWindow));

Can you please add a comment to the test explaining why we need to wait for the next tick here?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/451c5350e986
Wait for the next event tick before resolving promise in preferences test. r=jaws

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/451c5350e9867e973c0b7f97ab7790b6a551f8ca
Bug 1421118 - Wait for the next event tick before resolving promise in preferences test. r=jaws

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/451c5350e986