1421120 - Wait for the next event tick before resolving promise in webrtc tests.

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5800bb624450f22893e4918d653b3dbe231c4ac&selectedJob=147752999
> FAIL | browser/base/content/test/webrtc/browser_devices_get_user_media.js | video global indicator attribute as expected
> Got , expected true Stack trace: chrome://mochikit/content/browser-test.js:test_is:1269 chrome://mochitests/content/browser/browser/base/content/test/webrtc/head.js:assertWebRTCIndicatorStatus:151

after fixing bug 1193394, the test needs to wait for the next event tick before resolving promise in several events, to make sure everything gets ready.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Wait for the next event tick before resolving promise in webrtc tests.

promiseWindow, promisePopupEvent, promisePopupNotificationShown, and some other places in the test should wait for the next event tick before resolving the promise inside event handlers,
to avoid the remaining part of the testcase runs unexpectedly earlier,
after the change in bug 1193394.

Comment 2

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6050b349b801805f2e880a4183a7e1e87f01c098
Bug 1421120 - Wait for the next event tick before resolving promise in webrtc tests. r=Mossop

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1638eb8cf733
Backed out changeset 6050b349b801 for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s  r=backout on a CLOSED TREE

Comment 4

[Andreea Pavel [:apavel]]

Backed out changeset 56343b0de5c2 (bug 1424083) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1c819b56fe973b077d64737db186b066850e1197

Failure log: https://hg.mozilla.org/integration/mozilla-inbound/rev/a73f5a62f971efb9afa3b2e70b5d01b447ba3ed3

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/a73f5a62f971efb9afa3b2e70b5d01b447ba3ed3

Comment 5

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d289577579095aed29313a730d3e41c7738e78f8
Bug 1421120 - Wait for the next event tick before resolving promise in webrtc tests. r=Mossop

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d28957757909