Closed
Bug 1421134
Opened 7 years ago
Closed 7 years ago
Run MediaCacheStream::SetReadMode() off the main thread
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8932684 -
Flags: review?(bechen)
Attachment #8932685 -
Flags: review?(bechen)
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932684 [details] Bug 1421134. P1 - default MediaCacheStream::mCurrentMode to MODE_METADATA. https://reviewboard.mozilla.org/r/203750/#review209228
Attachment #8932684 -
Flags: review?(bechen) → review+
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932684 [details] Bug 1421134. P1 - default MediaCacheStream::mCurrentMode to MODE_METADATA. https://reviewboard.mozilla.org/r/203750/#review209230 https://searchfox.org/mozilla-central/source/dom/media/BaseMediaResource.h#67 Please also modify here.
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932685 [details] Bug 1421134. P2 - run MediaCacheStream::SetReadMode() off the main thread. https://reviewboard.mozilla.org/r/203752/#review209232
Attachment #8932685 -
Flags: review?(bechen) → review+
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8932684 -
Flags: review?(gsquelart)
Attachment #8932685 -
Flags: review?(gsquelart)
|
|
Assignee | |
Comment 6•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8932684 [details] Bug 1421134. P1 - default MediaCacheStream::mCurrentMode to MODE_METADATA. https://reviewboard.mozilla.org/r/203750/#review209230 Good catch! Thanks!
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932684 [details] Bug 1421134. P1 - default MediaCacheStream::mCurrentMode to MODE_METADATA. https://reviewboard.mozilla.org/r/203750/#review209244
Attachment #8932684 -
Flags: review?(gsquelart) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932685 [details] Bug 1421134. P2 - run MediaCacheStream::SetReadMode() off the main thread. https://reviewboard.mozilla.org/r/203752/#review209248
Attachment #8932685 -
Flags: review?(gsquelart) → review+
|
|
Assignee | |
Comment 9•7 years ago
|
||
Thanks for the reviews!
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 12•7 years ago
|
||
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b89049710a24 P1 - default MediaCacheStream::mCurrentMode to MODE_METADATA. r=bechen,gerald https://hg.mozilla.org/integration/autoland/rev/8b00dd26d6b5 P2 - run MediaCacheStream::SetReadMode() off the main thread. r=bechen,gerald
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b89049710a24 https://hg.mozilla.org/mozilla-central/rev/8b00dd26d6b5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•