1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Mark Liang(:mark_liang)]

Attachment: Circle icon with square drop shadow and white background

Currently, there's a square outline and dropshadow around icons in the "add to home screen" overlay. It should be removed, as it looks ugly with round icons. See the twitter example in the attachment.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

Review commit: https://reviewboard.mozilla.org/r/203412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203412/

Comment 2

[Max Liu [:maliu]]

Comment on attachment 8932362 [details]
Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

https://reviewboard.mozilla.org/r/203412/#review210110

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b40291b5264
[PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow. r=maliu

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0b40291b5264

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8932362 [details]
Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

Approval Request Comment
[Feature/Bug causing the regression]:When users click the PWA, a confirm dialog will display. We'll show the website icon here with rounded shadow. But the design has changed after it goes to beta.
[User impact if declined]: User will see old design and it's not pretty.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes ( by UX team)
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: It just change UI
[String changes made/needed]: no

Comment 6

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 59 (2017-12-06).
Devices:
Prestigio Grace X5 (Android 4.4.2)
Lenovo Yoga Tablet 2 (Android 4.4.2)
HTC 10 (Android 7.0.1)

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

I'd actually feel better if this was verified in beta...

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8932362 [details]
Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

pwa icons update.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/451e4043cf56