[PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow

VERIFIED FIXED in Firefox 58

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
11 months ago

People

(Reporter: mark_liang, Assigned: cnevinchen)

Tracking

(Blocks 1 bug)

Trunk
Firefox 59
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox57 unaffected, firefox58 fixed, firefox59 verified)

Details

(Whiteboard: [pwa-front-end][FNC][SPT59.2][MVP])

Attachments

(2 attachments)

Reporter

Description

2 years ago
Currently, there's a square outline and dropshadow around icons in the "add to home screen" overlay. It should be removed, as it looks ugly with round icons. See the twitter example in the attachment.
Reporter

Updated

2 years ago

Updated

2 years ago
Priority: -- → P1
Whiteboard: [pwa-front-end]

Updated

2 years ago
Whiteboard: [pwa-front-end] → [pwa-front-end][FNC][SPT59.2][MVP]

Comment 2

2 years ago
mozreview-review
Comment on attachment 8932362 [details]
Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

https://reviewboard.mozilla.org/r/203412/#review210110
Attachment #8932362 - Flags: review?(max) → review+

Comment 3

2 years ago
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b40291b5264
[PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow. r=maliu

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0b40291b5264
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8932362 [details]
Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

Approval Request Comment
[Feature/Bug causing the regression]:When users click the PWA, a confirm dialog will display. We'll show the website icon here with rounded shadow. But the design has changed after it goes to beta.
[User impact if declined]: User will see old design and it's not pretty.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes ( by UX team)
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: It just change UI
[String changes made/needed]: no
Attachment #8932362 - Flags: approval-mozilla-beta?

Comment 6

2 years ago
Verified as fixed on Nightly 59 (2017-12-06).
Devices:
Prestigio Grace X5 (Android 4.4.2)
Lenovo Yoga Tablet 2 (Android 4.4.2)
HTC 10 (Android 7.0.1)
I'd actually feel better if this was verified in beta...
Comment on attachment 8932362 [details]
Bug 1421149 - [PWA] Icons in the "Add to Home screen" overlay should not have outline & dropshadow.

pwa icons update.
Attachment #8932362 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Updated

11 months ago
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.