1421152 - Add a checked cast method to TenuredCell

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This is a follow-up of bug 1328948
see https://bugzilla.mozilla.org/show_bug.cgi?id=1328948#c7

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Hi Jonco
This is the patch for TenuredCell, however I didn't find any caller that could use as() instead.

Comment 2

[Jon Coppeard (:jonco)]

Comment on attachment 8932339 [details] [diff] [review]
Patch

Review of attachment 8932339 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

There's a couple of places in AtomMarkingRuntime::atomIsMarked() where we can use is/as on a TenuredCell.

::: js/src/gc/Marking.cpp
@@ +2015,5 @@
>  inline T*
>  MarkStack::TaggedPtr::as() const
>  {
>      MOZ_ASSERT(tag() == MapTypeToMarkStackTag<T*>::value);
> +    MOZ_ASSERT(ptr()->asTenured().is<T>());

We don't care about efficiency (so much) in assertions, so for simplicity these could be:

  MOZ_ASSERT(ptr()->isTenured());
  MOZ_ASERTT(ptr()->is<T>));

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72fbce0bb347
Add a checked cast method to TenuredCell. r=jonco

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/72fbce0bb347