Closed
Bug 1421163
Opened 7 years ago
Closed 7 years ago
Allow passing configuration to mozharness directly from taskcluster configuration.
Categories
(Release Engineering :: Applications: MozharnessCore, enhancement)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: tomprince, Assigned: tomprince)
Details
Attachments
(1 file)
Some mozharness config files are so simple, and only used once, that having an extra level of indirection is wasteful.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8932334 [details]
Bug 1421163: Allow passing configuration to mozharness directly from taskcluster configuration;
https://reviewboard.mozilla.org/r/203368/#review211144
::: testing/mozharness/mozharness/base/config.py:470
(Diff revision 1)
> else:
> raise
> +
> + if 'EXTRA_MOZHARNESS_CONFIG' in os.environ:
> + env_config = json.loads(os.environ['EXTRA_MOZHARNESS_CONFIG'])
> + all_cfg_files_and_dicts.append(("[EXTRA_MOZHARENSS_CONFIG]", env_config))
hm, why are we wrapping with square brackets within the string?
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8932334 [details]
Bug 1421163: Allow passing configuration to mozharness directly from taskcluster configuration;
https://reviewboard.mozilla.org/r/203368/#review211148
Not sure what is the expected norm in mozreview now but I'm setting to r- to signal I've read it. Re r? if you think the naming of the config file is right (open issue) or else submit new patch.
Attachment #8932334 -
Flags: review?(jlund) → review-
Assignee | ||
Comment 4•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8932334 [details]
Bug 1421163: Allow passing configuration to mozharness directly from taskcluster configuration;
https://reviewboard.mozilla.org/r/203368/#review211144
> hm, why are we wrapping with square brackets within the string?
I wanted to signal somehow that the config didn't come from a file, but rather something else (i.e. an environment variable). I'm happy to change this to something else.
Assignee | ||
Updated•7 years ago
|
Attachment #8932334 -
Flags: review- → review?(jlund)
Assignee | ||
Comment 5•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8932334 [details]
Bug 1421163: Allow passing configuration to mozharness directly from taskcluster configuration;
https://reviewboard.mozilla.org/r/203368/#review211144
> I wanted to signal somehow that the config didn't come from a file, but rather something else (i.e. an environment variable). I'm happy to change this to something else.
This is often done with `<`, but I thought that if it ever got passed to shell, then while `[` is special to the shell, it will just evaluate to a single-character filename, if anything.
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8932334 [details]
Bug 1421163: Allow passing configuration to mozharness directly from taskcluster configuration;
https://reviewboard.mozilla.org/r/203368/#review213966
sgtm
Attachment #8932334 -
Flags: review?(jlund) → review+
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/6239a7c3e034
Allow passing configuration to mozharness directly from taskcluster configuration; r=jlund
Comment 8•7 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•