1421164 - Manually visiting accounts.firefox.com may show your AMO account rather than your Sync account

Status: NEW

(Firefox :: Firefox Accounts, enhancement)

Description

[Mark Hammond [:markh] [:mhammond]]

For annoying reasons, I'm forced to use a different email address for AMO vs Sync. If I type accounts.firefox.com into the urlbar, I see my AMO account which surprised me - it took me a while to realize why the device list showed no devices.

Not a huge deal as all in-product elements which open the page do the right thing via query strings and/or other magic, and not many people are likely to be logged in this way, but rfkelly said to open it anyway for discussion.

Comment 1

[Ryan Kelly [:rfkelly]]

> all in-product elements which open the page do the right thing via query strings and/or other magic

I'm relieved to hear this part :-)

For context: if you open accounts.firefox.com with ?service=sync in the query params, we ask the browser itself for the signed-in account.  In other cases, we depend on information about your last signin that we stash in localStorage.

> not many people are likely to be logged in this way

I wonder how expensive it would be to gather some metrics on this.  Shane, how complex do you think it would be, to do a webchannel ping to the browser *and* look in localStorage, and log metrics if we find two different accounts?  (Not suggesting we do that with any urgency, just thinking about what a next step would look like).

Comment 2

[Shane Tomlinson [:stomlinson]]

(In reply to Ryan Kelly [:rfkelly] from comment #1)
> > all in-product elements which open the page do the right thing via query strings and/or other magic
> 
> I'm relieved to hear this part :-)
> 
> For context: if you open accounts.firefox.com with ?service=sync in the
> query params, we ask the browser itself for the signed-in account.  In other
> cases, we depend on information about your last signin that we stash in
> localStorage.
> 
> > not many people are likely to be logged in this way
> 
> I wonder how expensive it would be to gather some metrics on this.  Shane,
> how complex do you think it would be, to do a webchannel ping to the browser
> *and* look in localStorage, and log metrics if we find two different
> accounts?  (Not suggesting we do that with any urgency, just thinking about
> what a next step would look like).

It should be relatively straight forward. We always do the ping on Fx >= 55 
here [1] and store the response in [2]. We then update the user model from [3].
In [4], you should be able to compare the stored account state with the passed
in account state and log whether they are different.

[1] - https://github.com/mozilla/fxa-content-server/blob/045f688eed05b7ba005593333806a59a212c032b/app/scripts/models/auth_brokers/base.js#L125
[2] - https://github.com/mozilla/fxa-content-server/blob/045f688eed05b7ba005593333806a59a212c032b/app/scripts/models/auth_brokers/base.js#L142
[3] - https://github.com/mozilla/fxa-content-server/blob/045f688eed05b7ba005593333806a59a212c032b/app/scripts/lib/app-start.js#L400
[4] - https://github.com/mozilla/fxa-content-server/blob/045f688eed05b7ba005593333806a59a212c032b/app/scripts/models/user.js#L791