1421167 - Remove some dead single_locale configuration options.

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Tom Prince [:tomprince]]

All of these options only exist in the configuration files and a referenced nowhere else in-tree.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1421167: Remove some dead single_locale configuration options;

All of these options only exist in the configuration files and a referenced
nowhere else in-tree.

Review commit: https://reviewboard.mozilla.org/r/203372/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203372/

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8932338 [details]
Bug 1421167: Remove some dead single_locale configuration options;

https://reviewboard.mozilla.org/r/203372/#review208942

This looks good other than the one mention I placed about desktop_l10n.py here.

Thanks again for the work here, cleaning these up is high on my list of plans for the near future, since a LOT of this code is dead-code and cleanup will help immensely in comprehension of future changes.

::: testing/mozharness/configs/single_locale/linux.py
(Diff revision 1)
> -    "previous_mar_filename": "previous.mar",
> -    "current_work_mar_dir": "current.work",
> -    "package_base_dir": "dist/l10n-stage",
>      "application_ini": "application.ini",
> -    "buildid_section": 'App',
> -    "buildid_option": "BuildID",

buildid_* doesn't seem used from l10n, indeed. However this isn't complete

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/desktop_l10n.py#194

Note that: https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/mar.py#29 does reference this option, and that functions only caller is in MarMixin which DesktopL10n uses, however DesktopL10n doesn't actually call the relevant method so we're good.

Comment 3

[Tom Prince [:tomprince]]

Comment on attachment 8932338 [details]
Bug 1421167: Remove some dead single_locale configuration options;

https://reviewboard.mozilla.org/r/203372/#review208942

Yeah, I was trying to understand what options I needed to override for comm-central, and cleaning up the dead code I found makes that easier.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d38eadc46be
Remove some dead single_locale configuration options; r=Callek

Comment 5

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/1d38eadc46be

Comment 6

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d38eadc46be