1421168 - Needless declaration of VideoData::CreateAndCopyIntoTextureClient is left on the header file

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[YUKI "Piro" Hiroshi]

There is only the declaration of "VideoData::CreateAndCopyIntoTextureClient" but no implementation.
https://dxr.mozilla.org/mozilla-central/rev/cad9c9573579698c223b4b6cb53ca723cd930ad2/dom/media/MediaData.h#515
https://dxr.mozilla.org/mozilla-central/search?q=CreateAndCopyIntoTextureClient

The declaration and corresponding implementation are introduced by the commit:
https://hg.mozilla.org/mozilla-central/rev/906df3f2cce7
but the implementation is removed by:
https://hg.mozilla.org/mozilla-central/rev/d084c1f34802
and the declaration is left. The declaration should be removed also.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1421168 - Remove deadcode VideoData::CreateAndCopyIntoTextureClient.

There is only declaration but no definition.
Also, there is no caller. Remove it.

Review commit: https://reviewboard.mozilla.org/r/203382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203382/

Comment 2

[James Cheng[:JamesCheng]]

Thank you. I'll remove it.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8932344 [details]
Bug 1421168 - Remove deadcode VideoData::CreateAndCopyIntoTextureClient.

https://reviewboard.mozilla.org/r/203382/#review208806

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fa8c493c374
Remove deadcode VideoData::CreateAndCopyIntoTextureClient. r=gerald

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4fa8c493c374