Closed
Bug 1421192
Opened 7 years ago
Closed 7 years ago
Baldr: Ensure that sAlreadyInSignalHandler is initialized
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Actual results: The sAlreadyInSignalHandler thread local introduced in Bug 1294156 is not explicitly initialized resulting with crash on its usage on targets that do not define HAVE_THREAD_TLS_KEYWORD.
|
Assignee | |
Comment 1•7 years ago
|
||
Edit wrong bug number its Bug 1419224.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8932367 -
Flags: review?(luke)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8932367 [details] [diff] [review] bug1421192.patch Review of attachment 8932367 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! I assumed these were a simple thread_local wrapper but it looks like we still do the dynamic thing for WinXP even though it's not a support platform any more.
Attachment #8932367 -
Flags: review?(luke) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Assignee: nobody → dragan.mladjenovic
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/09e17c57592f Baldr: Ensure that sAlreadyInSignalHandler is initialized. r=luke
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/09e17c57592f
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•