[FIXr]line-through is drawn as underline

RESOLVED FIXED in mozilla1.4beta

Status

()

defect
P2
normal
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: kazhik, Assigned: bzbarsky)

Tracking

({testcase})

Trunk
mozilla1.4beta
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
"text-decoration: line-through" is drawn as underline.

Testcase:
http://bugzilla.mozilla.org/attachment.cgi?id=71636
(Reporter)

Comment 1

17 years ago
Posted image Screenshot
This worksforme, linux trunk build 2002-05-01-21
(Reporter)

Comment 3

17 years ago
This bug can be reprodoced with several Japanese fonts.

kaname-fixed: all lines are drawn as underline

shinonome-fixed: 9,10,15-32px are drawn as underline

alias-fixed: 16-18px are drawn as underline
jis-fixed: 16-18px are drawn as underline
misc-fixed: 16-18px are drawn as underline

aliastt-gothic: no problem
wadalab-gothic: no problem

Comment 4

17 years ago
When the property of a font property atom XA_X_HEIGHT is acquired, 
the value 0 is returned from X11 library XGetFontProperty() function.
In this case, line-through is drawn as underline.

Comment 5

17 years ago
Changing QA Contact
QA Contact: petersen → amar

Updated

17 years ago
Priority: -- → P2

Comment 6

17 years ago
Rbs, can you have a look at Hideo's patch, or delegate the review to someone else?
Target Milestone: --- → Future

Comment 7

17 years ago
Reproduced in 1/03/03 Linux trunk.
Keywords: testcase
(Assignee)

Updated

17 years ago
Attachment #82426 - Flags: review?(dbaron)
Attachment #82426 - Flags: review?(dbaron) → review+
(Assignee)

Updated

16 years ago
Attachment #82426 - Flags: superreview+
Comment on attachment 82426 [details] [diff] [review]
patch in case the font height is 0

Could this be approved for 1.4b?  This just sanity-checks the x-height that X
returns and treats it as unknown if 0 is returned...
Attachment #82426 - Flags: approval1.4b?
Taking to keep track of this.
Assignee: attinasi → bzbarsky
Summary: line-through is drawn as underline → [FIXr]line-through is drawn as underline
Target Milestone: Future → mozilla1.4beta
Comment on attachment 82426 [details] [diff] [review]
patch in case the font height is 0

a=sspitzer
Attachment #82426 - Flags: approval1.4b? → approval1.4b+
Checked in (and I patched xlib the same way too).
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 12

16 years ago
Boris Zbarsky wrote:
> Checked in (and I patched xlib the same way too).
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thanks! :)
You need to log in before you can comment on or make changes to this bug.