Closed Bug 1421238 Opened 6 years ago Closed 4 years ago

Intermittent browser/components/search/test/browser_oneOffHeader.js | Header has the correct index selected when a search engine has been selected - Got 1, expected 2

Categories

(Firefox :: Search, defect, P3)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
Firefox 60

People

(Reporter: intermittent-bug-filer, Assigned: bugzilla)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file)

Disable "browser_oneOffHeader.js" on OS.X
637 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review 
There have been 33 failures in the last week.
All the failures occur on OS X 10.10 / debug & opt.

Summary: Intermittent browser/components/search/test/browser_oneOffHeader.js | Header has the correct index selected when a search engine has been selected - Got 1, expected 2

Here is a recent log file:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=161007039&lineNumber=13151
Flags: needinfo?(florian)
Whiteboard: [stockwell needswork]
Flags: needinfo?(florian) → needinfo?(adw)
Assignee: nobody → adw
Status: NEW → ASSIGNED
Flags: needinfo?(adw)
Priority: P5 → P1
Over the last 7 days this bug has 45 occurrences, these happen on mostly on OS X 10.10 and macosx64-nightly

Here is the most recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=162564632&lineNumber=29171

Here is a relevant snippet from that log:

17:20:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_oneOffHeader.js | Header has the correct index selected when a search engine has been selected - Got 1, expected 2
17:20:06     INFO - Stack trace:
17:20:06     INFO - chrome://mochikit/content/browser-test.js:test_is:1271
17:20:06     INFO - chrome://mochitests/content/browser/browser/components/search/test/browser_oneOffHeader.js:test_text:121
17:20:06     INFO - Not taking screenshot here: see the one that was previously logged
17:20:06     INFO - TEST-UNEXPECTED-FAIL | browser/components/search/test/browser_oneOffHeader.js | Is the header text correct when search terms are entered after a search engine has been selected. - Got Search for foo with:, expected Search Google
Flags: needinfo?(florian)
I'm busy with other things right now and I'm not sure when I'll be able to get to this but I'll try to get to it soon.
Flags: needinfo?(florian) → needinfo?(adw)
The fail is mostly on OS X 10.10.
I`ve attached a patch to disable the test on "Mac" in case :adw decides we should disable it.
Attachment #8953675 - Flags: review?(jmaher)
Attachment #8953675 - Flags: review?(jmaher) → review+
adw: , it`s ok to disable it on OS X 10.10, or do you want to fix it?
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/890ace79df90
Disable browser_oneOffHeader.js on OS.X for frequent failures. r=jmaher
Keywords: checkin-needed
Sure, thank you.
https://hg.mozilla.org/mozilla-central/rev/890ace79df90
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Is it OK to leave this bug open until we get a fix?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
I pushed a patch to try that replaces the test's ad hoc synthesizeNativeMouseMove with the one from EventUtils.  It worked locally but seems to have made the failure permanent on try. :-/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=847c126599d75f0e90ebcf2c4ec3ff5879858543
Flags: needinfo?(adw)
Reopening as this is a disabled test that we should really fix.
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Keywords: leave-open

Given this got disabled, and it is still enabled on two other platforms, I think we're fine dropping this down to P3 at the moment.

Priority: P1 → P3

The work in bug 1561894 removes this test since the functionality of changing the header string no longer exists.

Depends on: 1561894

I'm marking as resolved since bug 1561894 landed and removed this test.

Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
Resolution: --- → WORKSFORME

Thanks, Harry. I forgot I was still assigned to this bug. I didn't fix it, so I'll change that. I'll assign you since your work fixed it.

Assignee: adw → htwyford
You need to log in before you can comment on or make changes to this bug.