1421259 - Too many events fired for JS module load errors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Jon Coppeard (:jonco)]

We currently currently fire an error event for every module dependency that fails to load in a module graph.  We should only fire a single event.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: bug1421259-fix-fetch-error-events

The first change is to make ScriptLoader::OnStreamComplete not fire an event for non-top-level modules.  However now we have to make sure top-level modules also fire error events.  Currently, inline script elements don't fire error events (because there can never be an error fetching an inline script).

I was unsure of the best way to do this.  What I've done here is to change the aIsInline parameter to ScriptElement::ScriptAvailable to aIsInlineClassicScript, because that is the test that we want to make.  This works but it isn't great because it leaks into the nsIScriptLoaderObserver interface.  Is this is OK or do you think there is there a better way to do this?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf6dde0deb8
Fix error events fired when loading JS module dependencies fail r=baku

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/aaf6dde0deb8