1421385 - Improve WR hit-testing correctness with respect to rounded corners

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

When I wrote the code to generate the nsDisplayCompositorHitTestInfo display items I mistakenly assumed they would get clip chains populated on them to deal with things like masks and rounded corners and whatnot. But they don't. So we need to fix that, probably by either moving where these items are created (so that the relevant clip-related RAII things are on the stack) or by wrapping the current call sites with the necessary RAII things.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP mochitest

This is the mochitest I have half-written. There might be bugs in it.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP mochitest

Rebased the mochitest. It's still failing, for the same reason (code is wrong).

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Kats, is this needed for release?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

If we haven't hit it so far maybe we don't need it for release, but we should do it for the "immediately after release" target.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

The plan for bug 1503046 will probably fix this.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: WIP mochitest

Rebased. Still fails.

Comment 7

[Glenn Watson [:gw]]

This happened.