Closed Bug 1421390 Opened 5 years ago Closed 5 years ago

Minor change to hidden node syntax color

Categories

(DevTools :: Inspector, enhancement, P3)

Product:
DevTools
Component:
Inspector
Version:
58 Branch
Type:
enhancement

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: victoria, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1421390 - Change hidden node syntax color in the markup view.
59 bytes, text/x-review-board-request
pbro
: review+
Details 
Some tweaks for var(--markup-hidden-attr-name-color):
Light mode: Change to #BA89B8
Dark mode: Change to #B07EB3

This makes the hidden nodes look a bit more subtle so that they're more easily distinguishable from the regular nodes.
Blocks: devtools-visual
Priority: -- → P3
Assignee: nobody → gl
Status: NEW → ASSIGNED
Comment on attachment 8943868 [details]
Bug 1421390 - Change hidden node syntax color in the markup view.

https://reviewboard.mozilla.org/r/214224/#review219954
Attachment #8943868 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce773f3e94ef
Change hidden node syntax color in the markup view. r=pbro
https://hg.mozilla.org/mozilla-central/rev/ce773f3e94ef
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.