1421419 - The X missing from search synced tabs sidebar

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

Attachment: gone.png

There used to be a clear icon on the right like History and Bookmarks. Let's bring it back.

Comment 1

[Edouard Oger [:eoger]]

Copy/pasting irc convers:

[16:12:16]  <eoger>	they removed .compact on .search-box
[16:12:50]  <eoger>	but if you don't have .compact you don't have the css rule here: https://searchfox.org/mozilla-central/rev/9f3bd430c2b132c86c46126a0548661de876799a/browser/themes/osx/syncedtabs/sidebar.css#125

This should be an easy enough fix.

Comment 2

[Edouard Oger [:eoger]]

Attachment: Bug 1421419 - Fix synced tabs sidebar searchbox on macOS.

Review commit: https://reviewboard.mozilla.org/r/216362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/216362/

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8946414 [details]
Bug 1421419 - Fix synced tabs sidebar searchbox on macOS.

https://reviewboard.mozilla.org/r/216362/#review222288

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d0ca31ba08d
Fix synced tabs sidebar searchbox on macOS. r=dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7d0ca31ba08d

Comment 6

[Mohammed Adam]

I Have tried to Reproduce the Same Bug in Firefox Nightly  60.0a1 (2018-02-20) on Windows 7 (32bit)

------------------------------------------------------------------------------------------
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0
OS: Windows_NT 6.1
Build ID: 20180220220044
Firefox Version:60.0a1
------------------------------------------------------------------------------------------

But the Bug has been Fixed. 

[Steps to Reproduce]
1) Start the Firefox with cleaned profile
2) Click view -> Sidebar -> Synced Tabs 
3) Synced tabs Sidebar will display

[Actual Results]
In the Right side of Search Synced Tabs sidebar, "X is not missing". 

Status: Fixed & Verified 

[bugday-20180221]