The X missing from search synced tabs sidebar

RESOLVED FIXED in Firefox 60

Status

()

defect
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: rfeeley, Assigned: eoger)

Tracking

55 Branch
Firefox 60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Posted image gone.png
There used to be a clear icon on the right like History and Bookmarks. Let's bring it back.
(Assignee)

Comment 1

a year ago
Copy/pasting irc convers:

[16:12:16]  <eoger>	they removed .compact on .search-box
[16:12:50]  <eoger>	but if you don't have .compact you don't have the css rule here: https://searchfox.org/mozilla-central/rev/9f3bd430c2b132c86c46126a0548661de876799a/browser/themes/osx/syncedtabs/sidebar.css#125

This should be an easy enough fix.
Priority: -- → P2
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Priority: P2 → P1

Comment 3

a year ago
mozreview-review
Comment on attachment 8946414 [details]
Bug 1421419 - Fix synced tabs sidebar searchbox on macOS.

https://reviewboard.mozilla.org/r/216362/#review222288

Thanks!
Attachment #8946414 - Flags: review?(dao+bmo) → review+

Comment 4

a year ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7d0ca31ba08d
Fix synced tabs sidebar searchbox on macOS. r=dao

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7d0ca31ba08d
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60

Comment 6

a year ago
I Have tried to Reproduce the Same Bug in Firefox Nightly  60.0a1 (2018-02-20) on Windows 7 (32bit)

------------------------------------------------------------------------------------------
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0
OS: Windows_NT 6.1
Build ID: 20180220220044
Firefox Version:60.0a1
------------------------------------------------------------------------------------------

But the Bug has been Fixed. 

[Steps to Reproduce]
1) Start the Firefox with cleaned profile
2) Click view -> Sidebar -> Synced Tabs 
3) Synced tabs Sidebar will display

[Actual Results]
In the Right side of Search Synced Tabs sidebar, "X is not missing". 

Status: Fixed & Verified 

[bugday-20180221]
You need to log in before you can comment on or make changes to this bug.