Closed Bug 1421428 Opened 6 years ago Closed 6 years ago

Failed to associate icons to topsites that redirect

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 61
Iteration:
61.2 - Apr 9
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- verified

People

(Reporter: Mardak, Assigned: nanj)

References

Details

(Whiteboard: [AS60MVP])

Attachments

(1 file)

      No description provided.
Iteration: 1.25 → 1.26
Iteration: 1.26 → 1.27
Iteration: 1.27 → 60.1 - Jan 29
There's an example of theguardian from https://github.com/mozilla/activity-stream/issues/3664

Where the root page redirects to some page on the same site.
Whiteboard: [AS60MVP]
Iteration: 60.1 - Jan 29 → 60.2 - Feb 12
This issue is no longer reproducible in nightly 60, all the missing icons (e.g. python.org, taobao.com etc.) mentioned in https://github.com/mozilla/activity-stream/issues/3788 are associated with either tippytop icons or regular favicons.

I couldn't find any change in placesutils.favicon.getIconForPage. So I'd guess this patch https://github.com/mozilla/activity-stream/commit/ce92c43ba20c2f2cc7b18b75ab1b2de3eeab84f9 in AS have fixed it.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
As expected, tippytop does fill some gap. I wonder how the regular (32x32) favicon association (americanexpress.com and taobao.com) got fixed though, it's also working now.
Blocks: 1435419
No longer blocks: 1435419
Depends on: 1421306
Target Milestone: --- → Firefox 58
Blocks: 1447479
Status: RESOLVED → REOPENED
Iteration: 60.2 - Feb 12 → ---
Resolution: FIXED → ---
Target Milestone: Firefox 58 → ---
Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/990d1140878870c5df156ca16ec5e02a009cf229
Fix Bug 1421428 - Link rich icon for redirected url

https://github.com/mozilla/activity-stream/commit/e8ef6e23b38c4eed36c6d0bf3f04516290b86ad9
Merge pull request #4057 from ncloudioj/bz1421428

Fix Bug 1421428 - Link rich icon for redirected url
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Blocks: 1449792
https://hg.mozilla.org/mozilla-central/rev/5dc20e8d5f71
Iteration: --- → 61.2 - Apr 9
Target Milestone: --- → Firefox 61
Build ID 	20180401220058
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have verified that the issue is no longer reproducible with the latest Nightly build on Windows 10 x64, Ubuntu 16.04, Arch Linux and Mac 10.13.3. The effects of this fix can be easily observed if you make a Top Site out of the https://www.fastmail.com/ or https://www.wealthsimple.com/ pages.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
See Also: → 1687135
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: