Closed
Bug 1421428
Opened 6 years ago
Closed 6 years ago
Failed to associate icons to topsites that redirect
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: nanj)
References
Details
(Whiteboard: [AS60MVP])
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•6 years ago
|
status-firefox58:
--- → wontfix
Reporter | ||
Updated•6 years ago
|
Iteration: 1.25 → 1.26
Updated•6 years ago
|
Iteration: 1.26 → 1.27
Reporter | ||
Updated•6 years ago
|
Iteration: 1.27 → 60.1 - Jan 29
Reporter | ||
Comment 1•6 years ago
|
||
There's an example of theguardian from https://github.com/mozilla/activity-stream/issues/3664 Where the root page redirects to some page on the same site.
Reporter | ||
Updated•6 years ago
|
status-firefox60:
--- → affected
Updated•6 years ago
|
Whiteboard: [AS60MVP]
Reporter | ||
Updated•6 years ago
|
Iteration: 60.1 - Jan 29 → 60.2 - Feb 12
Assignee | ||
Comment 2•6 years ago
|
||
This issue is no longer reproducible in nightly 60, all the missing icons (e.g. python.org, taobao.com etc.) mentioned in https://github.com/mozilla/activity-stream/issues/3788 are associated with either tippytop icons or regular favicons. I couldn't find any change in placesutils.favicon.getIconForPage. So I'd guess this patch https://github.com/mozilla/activity-stream/commit/ce92c43ba20c2f2cc7b18b75ab1b2de3eeab84f9 in AS have fixed it.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•6 years ago
|
||
I suppose most likely not actually fixed but problem not as big of a problem as before. Checking favicons.sqlite does indeed show: https://a0.muscache.com/airbnb/static/icons/android-icon-192x192-c0465f9f0380893768972a31a614b670.png#tippytop https://assets.guim.co.uk/images/favicons/451963ac2e23633472bf48e2856d3f04/152x152.png#tippytop https://img.alicdn.com/tfs/TB1VRA1RVXXXXawXFXXXXXXXXXX-180-180.png#tippytop https://www.python.org/static/apple-touch-icon-144x144-precomposed.png#tippytop Note the #tippytop.
Assignee | ||
Comment 4•6 years ago
|
||
As expected, tippytop does fill some gap. I wonder how the regular (32x32) favicon association (americanexpress.com and taobao.com) got fixed though, it's also working now.
Reporter | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Iteration: 60.2 - Feb 12 → ---
Resolution: FIXED → ---
Target Milestone: Firefox 58 → ---
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/990d1140878870c5df156ca16ec5e02a009cf229 Fix Bug 1421428 - Link rich icon for redirected url https://github.com/mozilla/activity-stream/commit/e8ef6e23b38c4eed36c6d0bf3f04516290b86ad9 Merge pull request #4057 from ncloudioj/bz1421428 Fix Bug 1421428 - Link rich icon for redirected url
Updated•6 years ago
|
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5dc20e8d5f71
Comment 9•6 years ago
|
||
Build ID 20180401220058 User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 I have verified that the issue is no longer reproducible with the latest Nightly build on Windows 10 x64, Ubuntu 16.04, Arch Linux and Mac 10.13.3. The effects of this fix can be easily observed if you make a Top Site out of the https://www.fastmail.com/ or https://www.wealthsimple.com/ pages.
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Updated•6 years ago
|
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•