Closed Bug 1421482 Opened 2 years ago Closed 2 years ago

[Pointer Event] Synthesize pointer events with mouse or touch events

Categories

(Core :: DOM: Events, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: stone, Assigned: stone)

References

Details

Attachments

(2 files)

We should follow the real use cases to synthesize mouse or touch events and generate pointer events so that the related logic is covered by these test cases.
Blocks: 1420589
Assignee: nobody → sshih
Priority: -- → P3
Summary: [Pointer Event] Replace test utility synthesizePointer with synthesizeMouse → [Pointer Event] Synthesize pointer events with mouse or touch events
Attachment #8933189 - Flags: review?(bugs)
Attachment #8933190 - Flags: review?(bugs)
Comment on attachment 8933189 [details] [diff] [review]
Part1: Revise test_bug968148.html to synthesize pointer events with touch events

rs+
Attachment #8933189 - Flags: review?(bugs) → review+
Comment on attachment 8933190 [details] [diff] [review]
Part2: Replace test utility synthesizePointer with synthesizeMouse

Yeah, this makes sense.
Attachment #8933190 - Flags: review?(bugs) → review+
Pushed by sshih@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d774f5fe6e94
Part1: Revise test_bug968148.html to synthesize pointer events with touch events. r=smaug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8701e1bd012
Part2: Replace test utility synthesizePointer with synthesizeMouse. r=smaug.
https://hg.mozilla.org/mozilla-central/rev/d774f5fe6e94
https://hg.mozilla.org/mozilla-central/rev/a8701e1bd012
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/554fbb5c6e5b
Backed out 2 changesets for failing modified mochitest layout/base/tests/test_bug1078327.html. r=backout a=backout
Backed out for failing modified mochitest layout/base/tests/test_bug1078327.html:

https://hg.mozilla.org/mozilla-central/rev/554fbb5c6e5ba9645c42a0cffe08d623df9e7488

Take a look at this push following the push of these changes: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=da352bea6602a09158d0e4d2c2bad81cb6078ee2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=151174726&repo=mozilla-inbound

> TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug1078327.html | pointerdown event should be received by target - got false, expected true
Please also check the other test failures.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla59 → ---
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #10)
> Backed out for failing modified mochitest
> layout/base/tests/test_bug1078327.html:
> 
> https://hg.mozilla.org/mozilla-central/rev/
> 554fbb5c6e5ba9645c42a0cffe08d623df9e7488
> 
> Take a look at this push following the push of these changes:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=da352bea6602a09158d0e4d2c2bad81cb6078ee2&filter-
> resultStatus=testfailed&filter-resultStatus=busted&filter-
> resultStatus=exception&filter-resultStatus=retry&filter-
> resultStatus=usercancel&filter-resultStatus=runnable
> Failure log:
> https://treeherder.mozilla.org/logviewer.html#?job_id=151174726&repo=mozilla-
> inbound
> 
> > TEST-UNEXPECTED-FAIL | layout/base/tests/test_bug1078327.html | pointerdown event should be received by target - got false, expected true
> Please also check the other test failures.

Hmm, these test cases are failed on android. We are not ready to support pointer event on android, so I'll disable them.
Flags: needinfo?(sshih)
Pushed by sshih@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34ea3896f3be
Part1: Revise test_bug968148.html to synthesize pointer events with touch events. r=smaug.
https://hg.mozilla.org/integration/mozilla-inbound/rev/75b0e10ee18a
Part2: Replace test utility synthesizePointer with synthesizeMouse. r=smaug.
https://hg.mozilla.org/mozilla-central/rev/34ea3896f3be
https://hg.mozilla.org/mozilla-central/rev/75b0e10ee18a
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
See Also: → 1424711
You need to log in before you can comment on or make changes to this bug.