Closed
Bug 1421483
Opened 7 years ago
Closed 7 years ago
Using correct frame to do hit test for touchstart with multiple touches
Categories
(Core :: DOM: Events, enhancement, P2)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: stone, Assigned: stone)
Details
Attachments
(1 file)
|
2.26 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sshih
|
||
Updated•7 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8933188 -
Flags: review?(bugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8933188 [details] [diff] [review] Using correct frame to do hit test for touchstart with multiple touches Do you have a testcase showing this being an issue? Or does GetEventCoordinatesRelativeTo + FindFrameTargetedByInputEvent currently anyhow end up returning the right target, as I expect.
Attachment #8933188 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Olli Pettay [:smaug] (ni?s and f?s processed after r?s) from comment #2) > Comment on attachment 8933188 [details] [diff] [review] > Using correct frame to do hit test for touchstart with multiple touches > > Do you have a testcase showing this being an issue? > Or does GetEventCoordinatesRelativeTo + FindFrameTargetedByInputEvent > currently anyhow end up returning the right target, as I expect. I found this when synthesizing a touchstart event with multiple 'new' touch instances. In that case, we use the hit frame of the first touch point as the input argument to do hit test for the second one and got null.
|
|
Assignee | |
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2693aaa71bdbcbd34c31baec55e59f6a47763596
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=629d0fd901b5ca2fb65ec4a7beb15371ff73c8fa
Pushed by sshih@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a296cf538ee1 Using correct frame to do hit test for touchstart with multiple touches. r=smaug.
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a296cf538ee1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•