Closed Bug 1421508 Opened 4 years ago Closed 3 years ago

Image sprite on BBC.com uses fallback

Categories

(Core :: Graphics: WebRender, enhancement, P2)

enhancement

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox59 --- affected

People

(Reporter: mstange, Assigned: ethlin)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wr-reserve])

With WebRender enabled and blob-images enabled, keyboard scrolling on http://www.bbc.com/news/world-europe-42157129 frequently janks.

This is caused by the fallback drawing of images that use this large sprite: http://static.bbci.co.uk/news/1.220.02180/img/news--icons-sprite.png .

For example, the phone icon next to the "On your mobile" text on the bottom of the page uses this sprite. The sprite is set as a background image on a ::before pseudo element.

With blob-images, drawing the image into a DrawTargetRecording puts all the pixels of the image into the recording, and we do that for every use of the image.

We should find out why these images are using fallback and make them stop using fallback.
Whiteboard: [wr-mvp] [triage]
Priority: -- → P3
Whiteboard: [wr-mvp] [triage] → [wr-mvp] [triage][wr-reserve-candidate]
Whiteboard: [wr-mvp] [triage][wr-reserve-candidate] → [wr-reserve]
The fallback checks in the nsDisplayBackgroundImage is a bit stange. I take a look.
Assignee: nobody → ethlin
Do you still see this?
Flags: needinfo?(mstange)
No, everything is smooth now. I don't see any fallback being used either.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(mstange)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.