1421553 - nsTextServicesDocument should handle native node instead of nsIDOMNode

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

OffsetEntry should hold nsINode instead of nsIDOMNode

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1421553 - Part 1. OffsetEntry should use nsINode instead of nsIDOMNode.

nsTextServicesDocument still use nsIDOMNode, so we should replace with nsINode
to reduce QI.

Review commit: https://reviewboard.mozilla.org/r/203828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203828/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1421553 - Part 2. Remove nsIDOMRange usages from nsTextServicesDocument.

nsITextServicesDocument isn't scriptable, so there is no reason to use
nsIDOMRange.

Review commit: https://reviewboard.mozilla.org/r/203830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203830/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8932772 [details]
Bug 1421553 - Part 1. OffsetEntry should use nsINode instead of nsIDOMNode.

https://reviewboard.mozilla.org/r/203828/#review209300

::: editor/txtsvc/nsTextServicesDocument.cpp:1725
(Diff revision 1)
>    nsCOMPtr<nsIDOMHTMLDocument> htmlDoc = do_QueryInterface(mDOMDocument);
>  
>    if (htmlDoc) {
>      // For HTML documents, the content root node is the body.
>  
>      nsCOMPtr<nsIDOMHTMLElement> bodyElement;
>  
>      nsresult rv = htmlDoc->GetBody(getter_AddRefs(bodyElement));

If we make it use nsIDocument, we can avoid using nsIDOMHTMLElement here, but out of scope of this bug.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8932773 [details]
Bug 1421553 - Part 2. Remove nsIDOMRange usages from nsTextServicesDocument.

https://reviewboard.mozilla.org/r/203830/#review209304

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4216488baf8f
Part 1. OffsetEntry should use nsINode instead of nsIDOMNode. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/bb87c7d4a364
Part 2. Remove nsIDOMRange usages from nsTextServicesDocument. r=masayuki

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4216488baf8f
https://hg.mozilla.org/mozilla-central/rev/bb87c7d4a364