Closed Bug 1421561 Opened 2 years ago Closed 2 years ago

Use IgnoredErrorResult in TextEditRules::WillInsertText()

Categories

(Core :: DOM: Editor, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- unaffected
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(3 files)

Hit the assertion of ErrorResult in Bug #1419799 comment #10.
Blocks: 1415509
Component: DOM → Editor
Comment on attachment 8932791 [details]
Bug 1421561 - Use IgnoredErrorResult in TextEditRules::WillInsertText();

https://reviewboard.mozilla.org/r/203846/#review209354

Thank you, please uplift this to beta 58. This is a regression of bug 1415509.
Attachment #8932791 - Flags: review?(masayuki) → review+
(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #3)
> please uplift this to beta 58. This is a regression of bug 1415509.

ni? to myself for tracking.
Flags: needinfo?(echen)
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09d275f79316
Use IgnoredErrorResult in TextEditRules::WillInsertText(); r=masayuki
https://hg.mozilla.org/mozilla-central/rev/09d275f79316
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8934044 [details] [diff] [review]
[Beta] Bug 1421561 - Use IgnoredErrorResult in TextEditRules::WillInsertText(); r=masayuki

Approval Request Comment
[Feature/Bug causing the regression]:
A regression of bug 1415509

[User impact if declined]:
Tab might crash.

[Is this code covered by automated tests?]: 
No. It is not clear how to trigger this without CustomElements feature.

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]:
No. It is not clear how to trigger this without CustomElements feature.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
Not risky.

[Why is the change risky/not risky?]:
Just suppress error to avoid assertion crash.

[String changes made/needed]:
None.
Attachment #8934044 - Flags: approval-mozilla-beta?
Attached file bug_1421561_test.html
(In reply to Edgar Chen [:edgar] from comment #8)
> Comment on attachment 8934044 [details] [diff] [review]
> [Beta] Bug 1421561 - Use IgnoredErrorResult in
> TextEditRules::WillInsertText(); r=masayuki
> 
> Approval Request Comment
> [Feature/Bug causing the regression]:
> A regression of bug 1415509
> 
> [User impact if declined]:
> Tab might crash.
> 
> [Is this code covered by automated tests?]: 
> No. It is not clear how to trigger this without CustomElements feature.

This testcase without CustomElements should be useful for automatic testing.

It crashes the tab for me on Linux and the whole browser on Android.

(Taking out the textarea content (a) would make the testcase pass on both platforms, just as another argument for the effectivness of this testcase.

Interestingly, in such an empty testcase, only manually entering a digit (e.g. 1) will crash the browser on Android, while an input crashes the tab on Linux.)
Comment on attachment 8934044 [details] [diff] [review]
[Beta] Bug 1421561 - Use IgnoredErrorResult in TextEditRules::WillInsertText(); r=masayuki

Fix a regression. Beta58+.
Attachment #8934044 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.