1421607 - Do black marking of bfcache documents during GC

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: black_windows.diff

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/95dd198e41c2ff2074b831ebe088ffaceda24741
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=95dd198e41c2ff2074b831ebe088ffaceda24741
remote: recorded changegroup in replication log in 0.053s

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This is tricky. nsIWindowWatcher can't be accessed there, since we have mock nsIWindowWatcher  implementations in JS.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: black_windows_2.diff

Approach 2
Use the window list.

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/9b95792f057e92ed44c17f4eed61fcb07ecee585
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b95792f057e92ed44c17f4eed61fcb07ecee585
remote: recorded changegroup in replication log in 0.048s

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Er, crap, the assertion is obviously wrong.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: black_windows_3.diff

remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/e7576181c7f13b7cef2b82023292889c42c3b261
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7576181c7f13b7cef2b82023292889c42c3b261
Crossing fingers this version will pass tests ;)

I wonder who should review this.
mystor for the PRCList usage...and I guess for everything.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8933024 [details] [diff] [review]
black_windows_3.diff

Review of attachment 8933024 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/731549261d94
Do black marking of bfcache documents during GC, r=mystor

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/731549261d94