Closed Bug 1421616 Opened 2 years ago Closed 2 years ago

Have one WebAuthnManager instance per CredentialsContainer

Categories

(Core :: DOM: Device Interfaces, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently have a single WebAuthnManager instance per process, that's shared between all the CredentialContainers. That way the nsPIDOMWindowInner parent has to be tracked by the transaction, as multiple containers could kick off requests simultaneously.

I suggest cleaning this up, so that we have one WebAuthnManager instance per each CredentialsContainer and thus each nsPIDOMWindowInner. Just like U2F has one instance per parent window too.

This simplifies the communication diagram (at least in my head) a little bit, as each U2F/WebAuthnManager instance also has their own TransactionChild for IPC protocol communication. The manager and child are destroyed when the parent window is.
We have to be careful here to not reintroduce bug 1403818.
Comment on attachment 8933246 [details]
Bug 1421616 - Have one WebAuthnManager instance per CredentialsContainer r?jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D305#7847
Attachment #8933246 - Flags: review+
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb739695f566
Have one WebAuthnManager instance per CredentialsContainer r=jcj
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/752801d6a020
Have one WebAuthnManager instance per CredentialsContainer r=jcj
https://hg.mozilla.org/mozilla-central/rev/752801d6a020
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.