1421616 - Have one WebAuthnManager instance per CredentialsContainer

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P2)

Description

[Tim Taubert [:ttaubert] (inactive)]

We currently have a single WebAuthnManager instance per process, that's shared between all the CredentialContainers. That way the nsPIDOMWindowInner parent has to be tracked by the transaction, as multiple containers could kick off requests simultaneously.

I suggest cleaning this up, so that we have one WebAuthnManager instance per each CredentialsContainer and thus each nsPIDOMWindowInner. Just like U2F has one instance per parent window too.

This simplifies the communication diagram (at least in my head) a little bit, as each U2F/WebAuthnManager instance also has their own TransactionChild for IPC protocol communication. The manager and child are destroyed when the parent window is.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

We have to be careful here to not reintroduce bug 1403818.

Comment 2

[Phabricator Automation]

Comment on attachment 8933246 [details]
Bug 1421616 - Have one WebAuthnManager instance per CredentialsContainer r?jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D305#7847

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb739695f566
Have one WebAuthnManager instance per CredentialsContainer r=jcj

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f54b084de4f9
Backed out changeset bb739695f566

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ace9151f2c596adf2dd44d5c07c842a7607763e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/752801d6a020
Have one WebAuthnManager instance per CredentialsContainer r=jcj

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/752801d6a020